From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Hui Zhu <teawater@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: Record segfault
Date: Mon, 28 Sep 2009 18:18:00 -0000 [thread overview]
Message-ID: <4AC0FD65.2080500@vmware.com> (raw)
In-Reply-To: <20090928155853.GA9003@adacore.com>
Joel Brobecker wrote:
> Michael,
>
>> This seems fine to me. Please check it into the main branch,
>> but don't add it to the release branch unless Joel says it's OK.
>
> It seems like a worthwhile patch to have, since it fixes a SEGV
> (right?). Are you confident about the patch? It seems relatively
> straightforward. My only comment is that it eliminates a query
> when the user types a record stop - is that desirable? I guess
> it is: What are the chances of someone typing "record stop" and
> not wanting to stop the recording session?
>
> In other words: I am ok with the patch being applied to the branch.
> If you are, can you give Hui the go-ahead?
OK, then, "go ahead", Hui. ;-)
next prev parent reply other threads:[~2009-09-28 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F7CE05678329534C957159168FA70DEC51535FFF95@EUSAACMS0703.eamcs.ericsson.se>
2009-09-12 2:39 ` Hui Zhu
2009-09-24 3:16 ` Hui Zhu
2009-09-26 22:35 ` Michael Snyder
2009-09-27 2:50 ` Hui Zhu
2009-09-28 18:07 ` Joel Brobecker
2009-09-28 18:18 ` Michael Snyder [this message]
2009-09-29 2:05 ` Hui Zhu
2009-09-29 2:07 ` Hui Zhu
2009-09-29 3:21 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC0FD65.2080500@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox