From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3702 invoked by alias); 28 Sep 2009 18:18:28 -0000 Received: (qmail 3694 invoked by uid 22791); 28 Sep 2009 18:18:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Sep 2009 18:18:23 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 45F6713099; Mon, 28 Sep 2009 11:18:21 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by jupiter.vmware.com (Postfix) with ESMTP id 3D8CBDC056; Mon, 28 Sep 2009 11:18:21 -0700 (PDT) Message-ID: <4AC0FD65.2080500@vmware.com> Date: Mon, 28 Sep 2009 18:18:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Joel Brobecker CC: Hui Zhu , gdb-patches ml , Marc Khouzam Subject: Re: Record segfault References: <4ABE96C8.6070702@vmware.com> <20090928155853.GA9003@adacore.com> In-Reply-To: <20090928155853.GA9003@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00881.txt.bz2 Joel Brobecker wrote: > Michael, > >> This seems fine to me. Please check it into the main branch, >> but don't add it to the release branch unless Joel says it's OK. > > It seems like a worthwhile patch to have, since it fixes a SEGV > (right?). Are you confident about the patch? It seems relatively > straightforward. My only comment is that it eliminates a query > when the user types a record stop - is that desirable? I guess > it is: What are the chances of someone typing "record stop" and > not wanting to stop the recording session? > > In other words: I am ok with the patch being applied to the branch. > If you are, can you give Hui the go-ahead? OK, then, "go ahead", Hui. ;-)