Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@false.org>
Subject: Re: [patch] use .gnu.attributes to detect e500 machine type
Date: Tue, 21 Jul 2009 15:41:00 -0000	[thread overview]
Message-ID: <4A65E118.3070103@qnx.com> (raw)
In-Reply-To: <4A526BF3.70102@qnx.com>

I haven't committed this... I made changes as per 
suggestion. Is it ok to commit?


Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
>> On Mon, Jul 06, 2009 at 12:33:51PM -0400, Aleksandar Ristovski wrote:
>>> ping?
>>>
>>> Note: new patch attached taking into account current_gdbarch removal.
>>
>> These look OK to me.  You might want to use the same style used for
>> other settings though: "auto (currently spe)".
>>
> 
> Changed accordingly:
> 
> $ ./gdb
> GNU gdb (GDB) 6.8.50.20090706-cvs
> (gdb) show powerpc vector-abi
> The current vector ABI is "auto" (currently "generic").
> (gdb) set powerpc vector-abi spe
> (gdb) show powerpc vector-abi
> The current vector ABI is "spe"
> (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE
> Reading symbols from 
> /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done.
> (gdb) show powerpc vector-abi
> The current vector ABI is "spe"
> (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe
> Load new symbol table from 
> "/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? (y or 
> n) y
> Reading symbols from 
> /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done.
> (gdb) show powerpc vector-abi
> The current vector ABI is "spe"
>                           ^^^^^^
>                   because we set it explicitly.
> (gdb) q
> 
> 
> Now auto selection:
> $ ./gdb
> ....
> (gdb) show powerpc vector-abi
> The current vector ABI is "auto" (currently "generic").
> (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE
> Reading symbols from 
> /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done.
> (gdb) show powerpc vector-abi
> The current vector ABI is "auto" (currently "spe").
> (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe
> Load new symbol table from 
> "/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? (y or 
> n) y
> Reading symbols from 
> /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done.
> (gdb) show powerpc vector-abi
> The current vector ABI is "auto" (currently "generic").
> (gdb)
> 
> 
> 
> Note that I made one change to my original proposal, namely in 
> rs6000_gdbarch_init, if vector_abi is  POWERPC_VEC_SPE we assume arch 
> bfd_arch_powerpc since if we are just changing the vector-abi without a 
> file, it would be unable to match target description.
> 
> 


-- 
Aleksandar Ristovski
QNX Software Systems


      reply	other threads:[~2009-07-21 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 14:48 Aleksandar Ristovski
2009-04-14 19:48 ` Aleksandar Ristovski
2009-04-28 21:31 ` Joel Brobecker
2009-05-22 19:21   ` Aleksandar Ristovski
2009-07-06 16:34     ` Aleksandar Ristovski
2009-07-06 17:48       ` Daniel Jacobowitz
2009-07-06 21:26         ` Aleksandar Ristovski
2009-07-21 15:41           ` Aleksandar Ristovski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A65E118.3070103@qnx.com \
    --to=aristovski@qnx.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox