From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3832 invoked by alias); 21 Jul 2009 15:39:33 -0000 Received: (qmail 3773 invoked by uid 22791); 21 Jul 2009 15:39:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from qnxmail.qnx.com (HELO qnxmail.qnx.com) (209.226.137.76) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Jul 2009 15:39:24 +0000 Received: from Nebula.ott.qnx.com (nebula.ott.qnx.com [10.42.3.30]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id LAA08022; Tue, 21 Jul 2009 11:39:12 -0400 Received: from [127.0.0.1] ([10.42.100.129]) by Nebula.ott.qnx.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 21 Jul 2009 11:39:17 -0400 Message-ID: <4A65E118.3070103@qnx.com> Date: Tue, 21 Jul 2009 15:41:00 -0000 From: Aleksandar Ristovski User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com CC: Daniel Jacobowitz Subject: Re: [patch] use .gnu.attributes to detect e500 machine type References: <20090428213118.GH31821@adacore.com> <4A16FB06.5080507@qnx.com> <20090706174836.GA22949@caradoc.them.org> <4A526BF3.70102@qnx.com> In-Reply-To: <4A526BF3.70102@qnx.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00510.txt.bz2 I haven't committed this... I made changes as per suggestion. Is it ok to commit? Aleksandar Ristovski wrote: > Daniel Jacobowitz wrote: >> On Mon, Jul 06, 2009 at 12:33:51PM -0400, Aleksandar Ristovski wrote: >>> ping? >>> >>> Note: new patch attached taking into account current_gdbarch removal. >> >> These look OK to me. You might want to use the same style used for >> other settings though: "auto (currently spe)". >> > > Changed accordingly: > > $ ./gdb > GNU gdb (GDB) 6.8.50.20090706-cvs > (gdb) show powerpc vector-abi > The current vector ABI is "auto" (currently "generic"). > (gdb) set powerpc vector-abi spe > (gdb) show powerpc vector-abi > The current vector ABI is "spe" > (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE > Reading symbols from > /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done. > (gdb) show powerpc vector-abi > The current vector ABI is "spe" > (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe > Load new symbol table from > "/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? (y or > n) y > Reading symbols from > /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done. > (gdb) show powerpc vector-abi > The current vector ABI is "spe" > ^^^^^^ > because we set it explicitly. > (gdb) q > > > Now auto selection: > $ ./gdb > .... > (gdb) show powerpc vector-abi > The current vector ABI is "auto" (currently "generic"). > (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE > Reading symbols from > /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done. > (gdb) show powerpc vector-abi > The current vector ABI is "auto" (currently "spe"). > (gdb) file /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe > Load new symbol table from > "/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? (y or > n) y > Reading symbols from > /home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done. > (gdb) show powerpc vector-abi > The current vector ABI is "auto" (currently "generic"). > (gdb) > > > > Note that I made one change to my original proposal, namely in > rs6000_gdbarch_init, if vector_abi is POWERPC_VEC_SPE we assume arch > bfd_arch_powerpc since if we are just changing the vector-abi without a > file, it would be unable to match target description. > > -- Aleksandar Ristovski QNX Software Systems