Re: [patch] nto target: Code cleanup

[Aleksandar Ristovski <aristovski@qnx.com>]

Aleksandar Ristovski wrote:
> Mark Kettenis wrote:
>>
>> Not sure this is a step in the right direction.  This being in a
>> -tdep.c file pretty much makes it impossible to build a multi-arch GDB
>> that supports multiple NTO targets.
>>
> 
> The patch functionally doesn't change anything. If you look at 
> nto-tdep.h there is current_nto_target extern which gets set either by 
> macros I used in my patch or indirectly by nto_set_target.
> 
> The patch removes the unnecessary indirection since it doesn't do what 
> one might expect.
> 
> Note that this approach works for multiarch but will definitely not work 
> once we enable gdb for multiple targets (of different architectures) at 
> the same time, and my patch doesn't change this situation.
> 

Mark do you agree? Are you ok with the patch?


Thanks,

-- 
Aleksandar Ristovski
QNX Software Systems