From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13233 invoked by alias); 12 Jun 2009 19:05:53 -0000 Received: (qmail 13224 invoked by uid 22791); 12 Jun 2009 19:05:53 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Jun 2009 19:05:45 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MFC4L-0005Aw-H4 for gdb-patches@sources.redhat.com; Fri, 12 Jun 2009 19:05:41 +0000 Received: from enigma.qnx.com ([209.226.137.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Jun 2009 19:05:41 +0000 Received: from aristovski by enigma.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Jun 2009 19:05:41 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: Re: [patch] nto target: Code cleanup Date: Fri, 12 Jun 2009 19:05:00 -0000 Message-ID: <4A32A6F7.9090709@qnx.com> References: <200906112039.n5BKdxrg027646@brahms.sibelius.xs4all.nl> <4A316D52.3010305@qnx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <4A316D52.3010305@qnx.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00340.txt.bz2 Aleksandar Ristovski wrote: > Mark Kettenis wrote: >> >> Not sure this is a step in the right direction. This being in a >> -tdep.c file pretty much makes it impossible to build a multi-arch GDB >> that supports multiple NTO targets. >> > > The patch functionally doesn't change anything. If you look at > nto-tdep.h there is current_nto_target extern which gets set either by > macros I used in my patch or indirectly by nto_set_target. > > The patch removes the unnecessary indirection since it doesn't do what > one might expect. > > Note that this approach works for multiarch but will definitely not work > once we enable gdb for multiple targets (of different architectures) at > the same time, and my patch doesn't change this situation. > Mark do you agree? Are you ok with the patch? Thanks, -- Aleksandar Ristovski QNX Software Systems