Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [patch] i386-nto-tdep.c - sigcontext
Date: Thu, 11 Jun 2009 20:41:00 -0000	[thread overview]
Message-ID: <4A316BD1.5090108@qnx.com> (raw)
In-Reply-To: <200906112033.n5BKXVp6017968@brahms.sibelius.xs4all.nl>

Mark Kettenis wrote:
>> From: Aleksandar Ristovski <aristovski@qnx.com>
>> Date:  Thu, 11 Jun 2009 14:53:19 -0400
>>
>> Hello,
>>
>> This is another cleanup patch for nto target (part of the 
>> ongoing effort to get my local changes into mainline).
>>
>> ChangeLog:
>> 	* i386-nto-tdep.c (I386_NTO_SIGCONTEXT_OFFSET): Remove define.
>> 	(i386nto_sigcontext_addr): Change the way context address 
>> is calculated.
>> 	(i386nto_init_abi): Remove usage of deprecated 
>> sc_reg_offset and
>> 	sc_sp_offset and set sc_reg_offset and sc_num_regs.
> 
> Hard for me to check the correctness of this diff, but the mechanism
> you're using does look correct.
> 

Thanks for looking at this Mark. I take your reply as 
approval? (correct me if I am wrong).

I should have probably added that the series of patches have 
been functionally tested (extensively) by QNX. I am just 
moving those changes to mainline.

(This is not to say that review is not necessary.)

Thank you,

-- 
Aleksandar Ristovski
QNX Software Systems


  reply	other threads:[~2009-06-11 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 18:53 Aleksandar Ristovski
2009-06-11 20:33 ` Mark Kettenis
2009-06-11 20:41   ` Aleksandar Ristovski [this message]
2009-06-11 20:57     ` Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A316BD1.5090108@qnx.com \
    --to=aristovski@qnx.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox