From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28224 invoked by alias); 11 Jun 2009 20:41:12 -0000 Received: (qmail 28216 invoked by uid 22791); 11 Jun 2009 20:41:11 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 20:41:06 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MEr53-0000Kz-EV for gdb-patches@sources.redhat.com; Thu, 11 Jun 2009 20:41:01 +0000 Received: from enigma.qnx.com ([209.226.137.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Jun 2009 20:41:01 +0000 Received: from aristovski by enigma.qnx.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Jun 2009 20:41:01 +0000 To: gdb-patches@sources.redhat.com From: Aleksandar Ristovski Subject: Re: [patch] i386-nto-tdep.c - sigcontext Date: Thu, 11 Jun 2009 20:41:00 -0000 Message-ID: <4A316BD1.5090108@qnx.com> References: <200906112033.n5BKXVp6017968@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Kettenis User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <200906112033.n5BKXVp6017968@brahms.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00324.txt.bz2 Mark Kettenis wrote: >> From: Aleksandar Ristovski >> Date: Thu, 11 Jun 2009 14:53:19 -0400 >> >> Hello, >> >> This is another cleanup patch for nto target (part of the >> ongoing effort to get my local changes into mainline). >> >> ChangeLog: >> * i386-nto-tdep.c (I386_NTO_SIGCONTEXT_OFFSET): Remove define. >> (i386nto_sigcontext_addr): Change the way context address >> is calculated. >> (i386nto_init_abi): Remove usage of deprecated >> sc_reg_offset and >> sc_sp_offset and set sc_reg_offset and sc_num_regs. > > Hard for me to check the correctness of this diff, but the mechanism > you're using does look correct. > Thanks for looking at this Mark. I take your reply as approval? (correct me if I am wrong). I should have probably added that the series of patches have been functionally tested (extensively) by QNX. I am just moving those changes to mainline. (This is not to say that review is not necessary.) Thank you, -- Aleksandar Ristovski QNX Software Systems