Re: PATCH: new gdb port: moxie-elf

[Anthony Green <green@moxielogic.com>]

Joel Brobecker wrote:
>> 2009-04-23  Anthony Green  <green@moxielogic.com>                         
>>          * moxie-tdep.h: New file.                                        
>>       * moxie-tdep.c: New file.                                           
>>    * configure.tgt: Add moxie-elf. 
>>     
>
> Looks good to me, after you fix the minor style issues reported below.
> Can you also send a patch announcing this new port in the NEWS file?
> You probably also need to update the MAINTAINERS file in the "Target
> Instruction Set Architectures" section to add your architecture to
> the list.  That way, gdb_buildall.sh will pick it up.
>
>   
Ok, thanks.  I'll do all of that.


> This target compiles with -Werror, right?
>
>   
Think so.  I'll confirm before I commit.


>> +static CORE_ADDR
>> +moxie_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
>>     
>
> I see that you decided to keep this function implementation as is.
> As long as it works for you, that's fine. I would be a little more
> concerned if this had any repercussions on the core-gdb maintainance,
> but I don't see this as being a potential problem.
>
>   
No, I changed this function to use skip_prologue_using_sal()./

>> +  /* No function symbol -- just return the PC. */
>>     
>
> Just an extra space missing here.
>
>   
>> +/* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy
>> +   frame.  The frame ID's base needs to match the TOS value saved by
>> +   save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint.  */
>>     
>
> This function description should be removed.
>
>   
>> +/* moxie register names. */
>>     
>
> Missing extra space :)
>
>   

I'll fix all of those and post the patch as committed.

Thanks Joel!

AG