From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18775 invoked by alias); 24 Apr 2009 01:02:19 -0000 Received: (qmail 18522 invoked by uid 22791); 24 Apr 2009 01:02:18 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtpauth01.prod.mesa1.secureserver.net (HELO smtpauth01.prod.mesa1.secureserver.net) (64.202.165.181) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 24 Apr 2009 01:02:14 +0000 Received: (qmail 28902 invoked from network); 24 Apr 2009 01:02:12 -0000 Received: from unknown (64.202.165.181) by smtpauth01.prod.mesa1.secureserver.net (64.202.165.181) with ESMTP; 24 Apr 2009 01:02:12 -0000 Message-ID: <49F10F94.3000107@moxielogic.com> Date: Fri, 24 Apr 2009 01:02:00 -0000 From: Anthony Green User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: PATCH: new gdb port: moxie-elf References: <20090423045725.aaa2c6acbe2fcbd4897bea2c255aade5.61d9530215.wbe@email03.secureserver.net> <20090423182851.GC7552@adacore.com> <49F0FC8C.4010204@moxielogic.com> <20090424000050.GK7552@adacore.com> In-Reply-To: <20090424000050.GK7552@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00683.txt.bz2 Joel Brobecker wrote: >> 2009-04-23 Anthony Green >> * moxie-tdep.h: New file. >> * moxie-tdep.c: New file. >> * configure.tgt: Add moxie-elf. >> > > Looks good to me, after you fix the minor style issues reported below. > Can you also send a patch announcing this new port in the NEWS file? > You probably also need to update the MAINTAINERS file in the "Target > Instruction Set Architectures" section to add your architecture to > the list. That way, gdb_buildall.sh will pick it up. > > Ok, thanks. I'll do all of that. > This target compiles with -Werror, right? > > Think so. I'll confirm before I commit. >> +static CORE_ADDR >> +moxie_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) >> > > I see that you decided to keep this function implementation as is. > As long as it works for you, that's fine. I would be a little more > concerned if this had any repercussions on the core-gdb maintainance, > but I don't see this as being a potential problem. > > No, I changed this function to use skip_prologue_using_sal()./ >> + /* No function symbol -- just return the PC. */ >> > > Just an extra space missing here. > > >> +/* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy >> + frame. The frame ID's base needs to match the TOS value saved by >> + save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint. */ >> > > This function description should be removed. > > >> +/* moxie register names. */ >> > > Missing extra space :) > > I'll fix all of those and post the patch as committed. Thanks Joel! AG