From: Carlos O'Donell <carlos@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: install-html and install-pdf improvements
Date: Mon, 20 Apr 2009 19:51:00 -0000 [thread overview]
Message-ID: <49ECD20C.9030100@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0904180924550.9094@digraph.polyomino.org.uk>
Joseph S. Myers wrote:
> On Sat, 18 Apr 2009, Eli Zaretskii wrote:
>
>> AFAICS, neither gdb/Makefile.in, nor anyone of the Makefile.in files
>> in its subdirectory, including gdb/doc/, uses $(docdir). So I'm
>> wondering why do we need a variable no one uses, and why do we pass it
>> to sub-Make?
>>
>> IOW, why not just have $(htmldir) and $(pdfdir) in the Makefile's, and
>> let the top-level configure figure out where they should be, based on
>> "--with-*dir" switches? The sub-Make's would then get these values
>> from the variables we pass to them, and there's no need to compute
>> $(docdir) again in subdirectories. Note that, even according to your
>> patch, gdb/doc/Makefile.in does not define nor use $(docdir), only the
>> other two. I'm asking why can't we do the same in gdb/ as well?
>
> Carlos, do you have any comments on the design underlying your patches
> here, regarding what directory variables should be defined in which
> makefiles? Were you aiming for each directory to be configurable
> independently when using a newer version of autoconf, so meaning that
> docdir and datarootdir should be defined in gdb/doc/Makefile.in, or for
> configuration always to be required to be at toplevel with directories
> expanded by make there and passed down in which case some variables may
> not be required in some subdirectories, or something else?
>
> The thread starts at
> <http://sourceware.org/ml/gdb-patches/2009-04/msg00424.html> and as far as
> I can see I did not make any changes to the sets of variables you defined
> in each directory.
The goal was to take a step towards behaving like the newer autoconf
would behave, and to allow independent configuration for each directory.
There should be values of docdir and datarootdir defined in
gdb/doc/Makefile.in, and if not specified, the values of pdfdir and
htmldir should be set to defaults as defined in the GNU Coding Standard.
The patch does not implement this last requirement, but that was the idea.
Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716
next prev parent reply other threads:[~2009-04-20 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 11:47 Joseph S. Myers
2009-04-17 15:26 ` Eli Zaretskii
2009-04-17 15:30 ` Joseph S. Myers
2009-04-17 18:18 ` Eli Zaretskii
2009-04-17 19:43 ` Tom Tromey
2009-04-17 19:49 ` Joseph S. Myers
2009-04-18 7:31 ` Eli Zaretskii
2009-04-18 9:32 ` Joseph S. Myers
2009-04-20 19:51 ` Carlos O'Donell [this message]
2009-04-20 20:56 ` Eli Zaretskii
2009-04-21 12:45 ` Joseph S. Myers
2009-04-21 18:54 ` Eli Zaretskii
2009-04-17 15:58 ` Joseph S. Myers
2009-04-17 16:58 ` Tom Tromey
2009-04-17 17:31 ` Daniel Jacobowitz
2009-04-17 18:47 ` Tom Tromey
2009-04-17 19:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ECD20C.9030100@codesourcery.com \
--to=carlos@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox