From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14338 invoked by alias); 20 Apr 2009 19:51:17 -0000 Received: (qmail 14328 invoked by uid 22791); 20 Apr 2009 19:51:16 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 19:51:04 +0000 Received: (qmail 5828 invoked from network); 20 Apr 2009 19:51:02 -0000 Received: from unknown (HELO ?192.168.2.102?) (carlos@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Apr 2009 19:51:02 -0000 Message-ID: <49ECD20C.9030100@codesourcery.com> Date: Mon, 20 Apr 2009 19:51:00 -0000 From: Carlos O'Donell User-Agent: Icedove 1.5.0.14eol (X11/20090105) MIME-Version: 1.0 To: "Joseph S. Myers" CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: install-html and install-pdf improvements References: <83hc0njo9e.fsf@gnu.org> <83bpqvjg96.fsf@gnu.org> <83skk6ifjr.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00538.txt.bz2 Joseph S. Myers wrote: > On Sat, 18 Apr 2009, Eli Zaretskii wrote: > >> AFAICS, neither gdb/Makefile.in, nor anyone of the Makefile.in files >> in its subdirectory, including gdb/doc/, uses $(docdir). So I'm >> wondering why do we need a variable no one uses, and why do we pass it >> to sub-Make? >> >> IOW, why not just have $(htmldir) and $(pdfdir) in the Makefile's, and >> let the top-level configure figure out where they should be, based on >> "--with-*dir" switches? The sub-Make's would then get these values >> from the variables we pass to them, and there's no need to compute >> $(docdir) again in subdirectories. Note that, even according to your >> patch, gdb/doc/Makefile.in does not define nor use $(docdir), only the >> other two. I'm asking why can't we do the same in gdb/ as well? > > Carlos, do you have any comments on the design underlying your patches > here, regarding what directory variables should be defined in which > makefiles? Were you aiming for each directory to be configurable > independently when using a newer version of autoconf, so meaning that > docdir and datarootdir should be defined in gdb/doc/Makefile.in, or for > configuration always to be required to be at toplevel with directories > expanded by make there and passed down in which case some variables may > not be required in some subdirectories, or something else? > > The thread starts at > and as far as > I can see I did not make any changes to the sets of variables you defined > in each directory. The goal was to take a step towards behaving like the newer autoconf would behave, and to allow independent configuration for each directory. There should be values of docdir and datarootdir defined in gdb/doc/Makefile.in, and if not specified, the values of pdfdir and htmldir should be set to defaults as defined in the GNU Coding Standard. The patch does not implement this last requirement, but that was the idea. Cheers, Carlos. -- Carlos O'Donell CodeSourcery carlos@codesourcery.com (650) 331-3385 x716