From: Simon Marchi <simon.marchi@polymtl.ca>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 00/10] Remove standalone ptid functions
Date: Thu, 14 Jun 2018 02:04:00 -0000 [thread overview]
Message-ID: <49903166aff66528df83fbda26001be8@polymtl.ca> (raw)
In-Reply-To: <20180613232228.GA2166@adacore.com>
On 2018-06-13 19:22, Joel Brobecker wrote:
>> This series removes the remaining standalone ptid functions in favor
>> of using methods on ptid_t.
>>
>> These patches were largely created by running a script.
>
> Looks like a very nice cleanup. I scanned through some of the patches,
> but not being the C++ expert in the group, I only did it out of
> curiosity for now. It looks fairly mechanical, as hinted by the fact
> that Tom said it was created by running a script.
>
> Anyone against the idea behind the change itself? Otherwise, I'd be
> inclined to allow Tom to self-review on that one.
>
> Thanks Tom!
Yay, thanks Tom, I did not have the courage to do that! I was just
waiting for Pedro to eliminate ptid_t completely with his multi-target
work :).
I sampled a few files, and it LGTM. I also built the cross-compiled
Linux configurations I have, and it went fine. If there's a compilation
failure resulting from this, it should be very easy to fix.
Simon
next prev parent reply other threads:[~2018-06-14 2:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 21:51 Tom Tromey
2018-06-13 21:51 ` [RFA 06/10] Remove ptid_is_pid Tom Tromey
2018-06-13 21:51 ` [RFA 03/10] Remove ptid_get_pid Tom Tromey
2018-06-13 21:51 ` [RFA 01/10] Remove ptid_build Tom Tromey
2018-06-13 21:51 ` [RFA 10/10] Remove ptid_equal Tom Tromey
2018-06-13 21:51 ` [RFA 07/10] Remove ptid_lwp_p Tom Tromey
2018-06-13 21:51 ` [RFA 08/10] Remove ptid_tid_p Tom Tromey
2018-06-13 21:51 ` [RFA 02/10] Remove pid_to_ptid Tom Tromey
2018-06-13 21:51 ` [RFA 09/10] Remove ptid_match Tom Tromey
2018-06-13 21:51 ` [RFA 05/10] Remove ptid_get_tid Tom Tromey
2018-06-13 21:51 ` [RFA 04/10] Remove ptid_get_lwp Tom Tromey
2018-06-13 23:22 ` [RFA 00/10] Remove standalone ptid functions Joel Brobecker
2018-06-14 2:04 ` Simon Marchi [this message]
2018-06-14 11:06 ` Pedro Alves
2018-06-14 15:42 ` Tom Tromey
2018-07-02 15:00 ` Tom Tromey
2018-07-03 13:54 ` Pedro Alves
2018-07-03 15:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49903166aff66528df83fbda26001be8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox