From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23866 invoked by alias); 14 Jun 2018 02:04:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23846 invoked by uid 89); 14 Jun 2018 02:04:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=courage, H*r:112, his X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 02:04:18 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5E24C1m000548 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Jun 2018 22:04:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 283201EF2A; Wed, 13 Jun 2018 22:04:12 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 65CBD1E481; Wed, 13 Jun 2018 22:04:10 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 14 Jun 2018 02:04:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 00/10] Remove standalone ptid functions In-Reply-To: <20180613232228.GA2166@adacore.com> References: <20180613215049.9691-1-tom@tromey.com> <20180613232228.GA2166@adacore.com> Message-ID: <49903166aff66528df83fbda26001be8@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 14 Jun 2018 02:04:12 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00349.txt.bz2 On 2018-06-13 19:22, Joel Brobecker wrote: >> This series removes the remaining standalone ptid functions in favor >> of using methods on ptid_t. >> >> These patches were largely created by running a script. > > Looks like a very nice cleanup. I scanned through some of the patches, > but not being the C++ expert in the group, I only did it out of > curiosity for now. It looks fairly mechanical, as hinted by the fact > that Tom said it was created by running a script. > > Anyone against the idea behind the change itself? Otherwise, I'd be > inclined to allow Tom to self-review on that one. > > Thanks Tom! Yay, thanks Tom, I did not have the courage to do that! I was just waiting for Pedro to eliminate ptid_t completely with his multi-target work :). I sampled a few files, and it LGTM. I also built the cross-compiled Linux configurations I have, and it went fine. If there's a compilation failure resulting from this, it should be very easy to fix. Simon