RFA: fix compilation warning

RFA: fix compilation warning

[Sandra Loosemore]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

I attempted to do a fresh checkout and build just now, and found it was failing 
with a variable-maybe-used-uninitialized compiler diagnostic.  The attached 
patch fixes it.  OK to check in?

-Sandra


[-- Attachment #2: gdb-compile.log --]
[-- Type: text/x-log, Size: 137 bytes --]

2008-12-26  Sandra Loosemore  <sandra@codesourcery.com>

	gdb/
	* breakpoint.c (update_watchpoint): Refactor to avoid compiler
	warning.

[-- Attachment #3: gdb-compile.patch --]
[-- Type: text/x-patch, Size: 1269 bytes --]

Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.367
diff -u -r1.367 breakpoint.c
--- gdb/breakpoint.c	22 Dec 2008 04:37:37 -0000	1.367
+++ gdb/breakpoint.c	26 Dec 2008 18:47:54 -0000
@@ -898,19 +898,23 @@
 	if ((b->type == bp_watchpoint || b->type == bp_hardware_watchpoint)
 	    && reparse)
 	  {
-	    int i, mem_cnt, target_resources_ok, other_type_used;
+	    int i, mem_cnt, other_type_used;
 
 	    i = hw_watchpoint_used_count (bp_hardware_watchpoint,
 					  &other_type_used);
 	    mem_cnt = can_use_hardware_watchpoint (val_chain);
 
-	    if (mem_cnt)
-	      target_resources_ok = TARGET_CAN_USE_HARDWARE_WATCHPOINT
-			 (bp_hardware_watchpoint, i + mem_cnt, other_type_used);
-	    if (!mem_cnt || target_resources_ok <= 0)
+	    if (!mem_cnt)
 	      b->type = bp_watchpoint;
 	    else
-	      b->type = bp_hardware_watchpoint;
+	      {
+		int target_resources_ok = TARGET_CAN_USE_HARDWARE_WATCHPOINT
+		  (bp_hardware_watchpoint, i + mem_cnt, other_type_used);
+		if (target_resources_ok <= 0)
+		  b->type = bp_watchpoint;
+		else
+		  b->type = bp_hardware_watchpoint;
+	      }
 	  }
 
       /* Look at each value on the value chain.  */

Re: RFA: fix compilation warning

[Daniel Jacobowitz]

On Fri, Dec 26, 2008 at 01:55:03PM -0500, Sandra Loosemore wrote:
> I attempted to do a fresh checkout and build just now, and found it was 
> failing with a variable-maybe-used-uninitialized compiler diagnostic.  The 
> attached patch fixes it.  OK to check in?
>
> -Sandra
>

> 2008-12-26  Sandra Loosemore  <sandra@codesourcery.com>
> 
> 	gdb/
> 	* breakpoint.c (update_watchpoint): Refactor to avoid compiler
> 	warning.

This is OK.

-- 
Daniel Jacobowitz
CodeSourcery