Re: [PATCH v3] gdb: fix "frame function" failure to get frame when call is it's last instruction

[Sahil <icegambit91@gmail.com>]

Hi,

Thank you for the review.

On Friday, July 5, 2024 6:36:52 PM GMT+5:30 Guinevere Larsen wrote:
> [...]
> I have tested, it fixes the issue reported and adds no regressions! I
> have a minor nit inlined, but with that fixes, feel free to add my git
> trailer to the commit message:
> 
> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> 
> I hope a maintainer approves this for pushing soon!
>
> [...]
> > diff --git a/gdb/testsuite/gdb.base/frame-selection.exp
> > b/gdb/testsuite/gdb.base/frame-selection.exp index e8d9c87c3a..4333f6a2d1
> > 100644
> > --- a/gdb/testsuite/gdb.base/frame-selection.exp
> > +++ b/gdb/testsuite/gdb.base/frame-selection.exp
> > @@ -63,7 +63,7 @@ proc check_frame { level address function } {
> > 
> >       set re [multi_line \
> >   		
> >   		"Stack level ${level}, frame at ($address):" \
> > 
> > -		".* = $hex in ${function} \(\[^\r\n\]*\); saved .* = $hex" \
> > +		".* = $hex in ${function}( \(\[^\r\n\]*\))*; saved .* = $hex" \
> 
> This looks like a spurious change. I removed the change and everything
> works.
> 
> There's no need to send a new version for just this change though, just
> fix it locally and apply my review tag :)
> 

Since this is my first time contributing to gdb, I am a little unsure
about what comes next.

My understanding is that a maintainer will respond to this thread
with an "Approved-By" tag and then I'll be able to push this patch
to the repository with the "Reviewed-By" and "Approved-By" tags
appended in the commit message. Is this correct?

Thanks,
Sahil