From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lcLXBPABiGZzhxwAWB0awg (envelope-from ) for ; Fri, 05 Jul 2024 10:23:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=WTqTvy9f; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 046211E0C3; Fri, 5 Jul 2024 10:23:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB73B1E030 for ; Fri, 5 Jul 2024 10:23:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 461013885C3F for ; Fri, 5 Jul 2024 14:23:41 +0000 (GMT) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 4A1A2388459B for ; Fri, 5 Jul 2024 14:23:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A1A2388459B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A1A2388459B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720189406; cv=none; b=pJ5Qs6yt6SV3hdLF9tyUMjU7jpIRtLKyyTWq/UD7sKAHe2dMAx5naWEN5FEtebG6frXOTQgqPYTVRaQCX/en5NZ9sGArTl4wf/2qQ1sYV3FIXKhT3T27lPHH1QuICLD7wYcX88bW8I1bI6bDEybk/iArATeG84vetJQIo1Vh4nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720189406; c=relaxed/simple; bh=Sn5bGPAsqrnKRHgOydaUuGvJPsbvSqaIBPtUQU4ulpA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=t3E2ieUjq9rr3kqViyWsBGOCzdo5D7ER5vOuLn02lyN4o3I5223Oi9M1FabzxoUGexKZyexGs8qEYhd6GBZOKV8y3CHMeSXy5foyQwlL+qY+qyv2puVxeeyxlL/O1lmoEcv9SfdBbsHAM7cmKH8CbDVKqsp+5r3xnc7N4tiWrMc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1fb222a8eaeso12888515ad.3 for ; Fri, 05 Jul 2024 07:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720189403; x=1720794203; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bf+Hp3fm1Z9OEfYaaeUXA737zBpDAzjPsIQvRnzSuBg=; b=WTqTvy9f/YlflSGB8FMGi7MyR84cBJQ5V48n1GcA+HNi5fyVY0929bLSh38oLx+m9a UWUKiTBZn/WXHAqMbFL24sIzqs1Xx2EVSD6wwV28eCnVwGK/YkbJlQYZLV6GRfHWZoDi NIbd2nR/2fVRQ5tFIC6l/8oBjMVbI5NtaHhJv2RAtkjSKjC5kBXDJlEhY66libjR/A3P Wp3M4kRN0PcZws1qYn5ZGIml1dr4EGHbMXUkasDpM7DjgFfHdO494VLwftURm/3yBg8m uRnONn915kJkGNJpaJCa33qiCqbG94zDJo9UGeknOHjycP69oKzE8f4Zd2U4woyl5bui szbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720189403; x=1720794203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bf+Hp3fm1Z9OEfYaaeUXA737zBpDAzjPsIQvRnzSuBg=; b=hsVK/LMa9fVhNffAPr/TP/h2/bJ5vBGUObv2p84krFxbBYDmLgO2hhCyQuXdcoOesP 5AUi+j+oIR3OI3dkMA5p5zgjfsA0CYAkBaXGUGteVKQdLnkSRn9cSvESbAPmKVBdf+gR 9//efgJMh3CgGXrFJPVxb1OMONJczufQ1Eol0tiaO/p8PlTI0sE8vTZ1lHGlfPxUfwS9 bn5B/cE578/gRLtpURTxrluQVusXQRP8MF/qxT9c4eQ1LPil9CdiF9CvvaMcGuNUSjD6 ENoLObIc6HC4YmOdhzyd38W9b0R1fx66Ew7dNOhED32Z/3y0hN4ocPJJhsGZl2EuQO9R mvMQ== X-Gm-Message-State: AOJu0YzWI0KVDHDNI1r9CEvmBFj8uBN3unNdf9Lwoe3fbRrND5Vy81fb Gv2YYUrqXDUlIBcz6WExn36IzQAKtnUh7Q3CnYlldHNbB+nZZ1S4mR+kEw== X-Google-Smtp-Source: AGHT+IFC5P7RLjMky7+lyGFodaM50peRuVUTyohnX5KqFh+vfe5qxS4O2LyM2MpmfStqnSFMkzOSPw== X-Received: by 2002:a17:902:dac6:b0:1f9:fb39:2fb5 with SMTP id d9443c01a7336-1fb33e1a630mr44449045ad.21.1720189402956; Fri, 05 Jul 2024 07:23:22 -0700 (PDT) Received: from valdaarhun.localnet ([114.79.174.115]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac10d1460sm141126395ad.25.2024.07.05.07.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 07:23:22 -0700 (PDT) From: Sahil To: gdb-patches@sourceware.org, Guinevere Larsen Cc: Sahil Siddiq Subject: Re: [PATCH v3] gdb: fix "frame function" failure to get frame when call is it's last instruction Date: Fri, 05 Jul 2024 19:53:19 +0530 Message-ID: <4933009.GXAFRqVoOG@valdaarhun> In-Reply-To: References: <20240704163348.67304-1-sahilcdq@proton.me> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, Thank you for the review. On Friday, July 5, 2024 6:36:52=E2=80=AFPM GMT+5:30 Guinevere Larsen wrote: > [...] > I have tested, it fixes the issue reported and adds no regressions! I > have a minor nit inlined, but with that fixes, feel free to add my git > trailer to the commit message: >=20 > Reviewed-By: Guinevere Larsen >=20 > I hope a maintainer approves this for pushing soon! > > [...] > > diff --git a/gdb/testsuite/gdb.base/frame-selection.exp > > b/gdb/testsuite/gdb.base/frame-selection.exp index e8d9c87c3a..4333f6a2= d1 > > 100644 > > --- a/gdb/testsuite/gdb.base/frame-selection.exp > > +++ b/gdb/testsuite/gdb.base/frame-selection.exp > > @@ -63,7 +63,7 @@ proc check_frame { level address function } { > >=20 > > set re [multi_line \ > > =09 > > "Stack level ${level}, frame at ($address):" \ > >=20 > > - ".* =3D $hex in ${function} \(\[^\r\n\]*\); saved .* =3D $hex" \ > > + ".* =3D $hex in ${function}( \(\[^\r\n\]*\))*; saved .* =3D $hex" \ >=20 > This looks like a spurious change. I removed the change and everything > works. >=20 > There's no need to send a new version for just this change though, just > fix it locally and apply my review tag :) >=20 Since this is my first time contributing to gdb, I am a little unsure about what comes next. My understanding is that a maintainer will respond to this thread with an "Approved-By" tag and then I'll be able to push this patch to the repository with the "Reviewed-By" and "Approved-By" tags appended in the commit message. Is this correct? Thanks, Sahil