Re: [PATCH] hurd: Fix RPC link names

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2022-01-31 20:23, Samuel Thibault wrote:
> Simon Marchi, le lun. 31 janv. 2022 20:05:53 -0500, a ecrit:
>>
>>
>> On 2022-01-31 20:05, Samuel Thibault wrote:
>>> Simon Marchi, le lun. 31 janv. 2022 19:56:35 -0500, a ecrit:
>>>> On 2022-01-31 19:04, Samuel Thibault via Gdb-patches wrote:
>>>>> The RPC stub code expects to be calling a C function, not a C++
>>>>> function.
>>>>>
>>>>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
>>>>> index 67ce00e9c30..030ccf01d68 100644
>>>>> --- a/gdb/gnu-nat.c
>>>>> +++ b/gdb/gnu-nat.c
>>>>> @@ -1766,11 +1766,13 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port)
>>>>>  
>>>>>  \f
>>>>>  #define ILL_RPC(fun, ...) \
>>>>> +  extern "C" { \
>>>>>    extern kern_return_t fun (__VA_ARGS__); \
>>>>
>>>> I think this could be on a single line:
>>>>
>>>>   extern "C" kern_return_t fun..
>>>
>>> Ah right here is a simplified version.
>>>
>>> Samuel
>>>
>>>
>>> The RPC stub code expects to be calling a C function, not a C++
>>> function.
>>>
>>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
>>> index e0219b1a3ff..81676308882 100644
>>> --- a/gdb/gnu-nat.c
>>> +++ b/gdb/gnu-nat.c
>>> @@ -1766,7 +1766,7 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port)
>>>  
>>>  \f
>>>  #define ILL_RPC(fun, ...) \
>>> -  extern kern_return_t fun (__VA_ARGS__); \
>>> +  extern "C" kern_return_t fun (__VA_ARGS__); \
>>>    kern_return_t fun (__VA_ARGS__) \
>>>    { \
>>>      warning (_("illegal rpc: %s"), #fun); \
>>
>> Thanks, this is OK to push.
> 
> (I don't have commit access)
> 
> Samuel

Oh, sorry!  Pushed it for you.

Simon