From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qMI0DoyN+GFyDQAAWB0awg (envelope-from ) for ; Mon, 31 Jan 2022 20:31:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 2907B1F3B4; Mon, 31 Jan 2022 20:31:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF2281EDF0 for ; Mon, 31 Jan 2022 20:31:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DFC563858421 for ; Tue, 1 Feb 2022 01:31:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DFC563858421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643679114; bh=5lI5Zr5ogrHPm66GnxmLIWMC7AGEvYlX1SC+CQ2GBGw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=glstDrf2pj+1C7lpOdQlNygzX52t8Msm3ruNPOgO39JiMGZDCiEd+OQpEzkFU6m6H 3sPGgzrR3uct/sunrnfQagWW7O3l0iyassZ9M8Pxnj8D282/hy0u7xlBwJfrKT/gVn L9d6GS2Vc+MpJ+pWDPsLPl9oKMZ+/uSrYCEeRGv0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 660503858D35 for ; Tue, 1 Feb 2022 01:31:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 660503858D35 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2111VN47014398 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Jan 2022 20:31:27 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2111VN47014398 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B59CE1EDF0; Mon, 31 Jan 2022 20:31:22 -0500 (EST) Message-ID: <48fd3788-7943-6576-3918-748508e26c43@polymtl.ca> Date: Mon, 31 Jan 2022 20:31:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] hurd: Fix RPC link names Content-Language: en-US To: Samuel Thibault References: <20220201000450.2lfmwt6hwyd2qcg5@begin> <0f896293-65d3-28bf-ef43-d965a1114136@polymtl.ca> <20220201010509.vhrffe26klj26yce@begin> <20220201012313.kvhplo47mk5fe3ch@begin> In-Reply-To: <20220201012313.kvhplo47mk5fe3ch@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 1 Feb 2022 01:31:23 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Thomas Schwinge , gdb-patches@sourceware.org, thomas@schwinge.name Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-01-31 20:23, Samuel Thibault wrote: > Simon Marchi, le lun. 31 janv. 2022 20:05:53 -0500, a ecrit: >> >> >> On 2022-01-31 20:05, Samuel Thibault wrote: >>> Simon Marchi, le lun. 31 janv. 2022 19:56:35 -0500, a ecrit: >>>> On 2022-01-31 19:04, Samuel Thibault via Gdb-patches wrote: >>>>> The RPC stub code expects to be calling a C function, not a C++ >>>>> function. >>>>> >>>>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c >>>>> index 67ce00e9c30..030ccf01d68 100644 >>>>> --- a/gdb/gnu-nat.c >>>>> +++ b/gdb/gnu-nat.c >>>>> @@ -1766,11 +1766,13 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) >>>>> >>>>> >>>>> #define ILL_RPC(fun, ...) \ >>>>> + extern "C" { \ >>>>> extern kern_return_t fun (__VA_ARGS__); \ >>>> >>>> I think this could be on a single line: >>>> >>>> extern "C" kern_return_t fun.. >>> >>> Ah right here is a simplified version. >>> >>> Samuel >>> >>> >>> The RPC stub code expects to be calling a C function, not a C++ >>> function. >>> >>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c >>> index e0219b1a3ff..81676308882 100644 >>> --- a/gdb/gnu-nat.c >>> +++ b/gdb/gnu-nat.c >>> @@ -1766,7 +1766,7 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) >>> >>> >>> #define ILL_RPC(fun, ...) \ >>> - extern kern_return_t fun (__VA_ARGS__); \ >>> + extern "C" kern_return_t fun (__VA_ARGS__); \ >>> kern_return_t fun (__VA_ARGS__) \ >>> { \ >>> warning (_("illegal rpc: %s"), #fun); \ >> >> Thanks, this is OK to push. > > (I don't have commit access) > > Samuel Oh, sorry! Pushed it for you. Simon