From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] ada: Use std::string in print_dynamic_range_bound
Date: Sat, 14 Oct 2017 02:46:00 -0000 [thread overview]
Message-ID: <48e5cd75088663ad48f30ec06ab01400@polymtl.ca> (raw)
In-Reply-To: <20171013202945.GL8425@1170ee0b50d5>
On 2017-10-13 16:29, Yao Qi wrote:
> On 17-10-13 09:45:47, Simon Marchi wrote:
>> Replace this usage of GROW_VECT with an std::string. I don't think
>> there's a reason for this variable to be static, other than it was
>> cumbersome to manage its lifetime (i.e. use a cleanup) before.
>>
>> Tested by comparing the gdb.ada/*.exp test results before and after
>> the
>> patch.
>>
>> gdb/ChangeLog:
>>
>> * ada-typeprint.c (print_dynamic_range_bound): Use std::string.
>
> Patch is good to me.
Thanks, pushed.
prev parent reply other threads:[~2017-10-14 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:46 Simon Marchi
2017-10-13 20:29 ` Yao Qi
2017-10-14 2:46 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e5cd75088663ad48f30ec06ab01400@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox