From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21402 invoked by alias); 14 Oct 2017 02:46:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21054 invoked by uid 89); 14 Oct 2017 02:46:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Oct 2017 02:46:50 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v9E2khoo027900 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Oct 2017 22:46:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 9D2741E541; Fri, 13 Oct 2017 22:46:43 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B6B5D1E523; Fri, 13 Oct 2017 22:46:42 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 14 Oct 2017 02:46:00 -0000 From: Simon Marchi To: Yao Qi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] ada: Use std::string in print_dynamic_range_bound In-Reply-To: <20171013202945.GL8425@1170ee0b50d5> References: <1507902347-7971-1-git-send-email-simon.marchi@ericsson.com> <20171013202945.GL8425@1170ee0b50d5> Message-ID: <48e5cd75088663ad48f30ec06ab01400@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 14 Oct 2017 02:46:43 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00384.txt.bz2 On 2017-10-13 16:29, Yao Qi wrote: > On 17-10-13 09:45:47, Simon Marchi wrote: >> Replace this usage of GROW_VECT with an std::string. I don't think >> there's a reason for this variable to be static, other than it was >> cumbersome to manage its lifetime (i.e. use a cleanup) before. >> >> Tested by comparing the gdb.ada/*.exp test results before and after >> the >> patch. >> >> gdb/ChangeLog: >> >> * ada-typeprint.c (print_dynamic_range_bound): Use std::string. > > Patch is good to me. Thanks, pushed.