From: Craig Blackmore <craig.blackmore@embecosm.com>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Cc: Simon Cook <simon.cook@embecosm.com>
Subject: Re: [PATCH] Add missing null pointer check in get_sal_arch
Date: Thu, 8 Oct 2026 13:34:22 +0100 [thread overview]
Message-ID: <48cd6cef-8ecd-4bcc-85cf-25c821c2fae3@embecosm.com> (raw)
In-Reply-To: <4ecef44c-61e1-4f20-ae9d-d177edd429e1@embecosm.com>
On 21/08/2026 11:25, Craig Blackmore wrote:
>
> Thanks for looking into this and sharing your analysis and alternative
> fix. I much prefer your fix as it addresses the root cause and it works
> on both my original test and the updated test that I just posted.
>
> As you've written the fix, would you prefer to add my test to your patch
> or for me to combine everything into a new submission?
Hi Andrew,
Did you have any thoughts on how you would like to proceed?
Thanks,
Craig
prev parent reply other threads:[~2026-10-08 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 15:06 Craig Blackmore
2026-07-31 13:27 ` Tom de Vries
2026-08-21 9:51 ` Craig Blackmore
2026-07-31 13:54 ` Andrew Burgess
2026-08-21 10:09 ` Craig Blackmore
2026-07-31 14:31 ` Andrew Burgess
2026-07-31 15:27 ` Andrew Burgess
2026-08-21 10:25 ` Craig Blackmore
2026-10-08 12:34 ` Craig Blackmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48cd6cef-8ecd-4bcc-85cf-25c821c2fae3@embecosm.com \
--to=craig.blackmore@embecosm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.cook@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox