From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0cw+Mv+Nx2qvDxYAWB0awg (envelope-from ) for ; Thu, 08 Oct 2026 08:35:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Pk484PoS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B7C6B1E04E; Thu, 08 Oct 2026 08:35:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0F1D1E04E for ; Thu, 08 Oct 2026 08:35:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 777E24BA2E32 for ; Thu, 8 Oct 2026 12:35:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 777E24BA2E32 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Pk484PoS Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 99B764BA2E06 for ; Thu, 8 Oct 2026 12:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99B764BA2E06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99B764BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791462869; cv=none; b=lUSIOwBCuYl6uLZJzmYwHyTj2sjQ3WUmLp+F6B5GQ1jlaUUaKgw0fRNKxCFZxdbXjRFi7h8VQhoWRwwEnYf5b8AgHYSsf6jrggGoekNyhyYAZOsbcn7pA7uUbL6bDHvAtXvuNWmewJZ8Sl5xy6tu5NBGwpVBUo+gQUu89oOcixM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791462869; c=relaxed/simple; bh=XikHQ7AogRfi0wxD/S4R3qwOwVcIlwJXBS2eZWeyOz8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=hE2ejAIbWnMa6JP90ASGB35LVYeOX9AyPzyoebJ/Xwn6p7d2xXBObbn+adIoPLk98Whn/UP8JE1i/ixxte7XHZfZWvPFatMW9bCSvpvLYNJMjxDOg/Y67i6VWut8yVU0iJp8OkSJJ4/91JDHZm+4BzWcY4T/SwlPM5yE8PzmGyc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=Pk484PoS DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99B764BA2E06 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-6afafc89b48so4633123a12.2 for ; Thu, 08 Oct 2026 05:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1791462863; x=1792067663; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XikHQ7AogRfi0wxD/S4R3qwOwVcIlwJXBS2eZWeyOz8=; b=Pk484PoSuGiRmg0VZptRzo6KgfMYj+A4yvB8dBc7g6VoqP9ZO3tQamkgDOE/fyWemP jKDaAOR3NJVexnJPdCJfY/DRPlTGcYWwDShCsFrExM9zXPCOEC7C1rgfOGasbcF5yJYx 1np5EMYFQmIWQdxY0mMzgsxwjA6zDk83uUxhHd43aWFhdkW9JHcLWQSraiRKY5zo6bRO lxffZXgX7ulaZYopkUOc8xlVDB+0wmhT5sYSGyRg7gsH6PnMgTROlfDwF8k1XvQHP2z/ I3emEFgyLqsWpKyVDlv9V3wQYDzNKhFDJ1yjp0M0nLLS9wnK+bpez/vMZTTL4QPo61PA wxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791462863; x=1792067663; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XikHQ7AogRfi0wxD/S4R3qwOwVcIlwJXBS2eZWeyOz8=; b=W8DwDW1r60et58+eecRNdRZYj9RLzXx8it61S9G9xLcoLQ7xLa06bd+O6cnmxn18gT fYazNHBOjohtLHgwVNAqjmvgks+E+ddY7mb2p54YfCsZ3wdxBICQTqNmtFemDdSwXx3V ovRNXmWyjnmQOphexLY0xnk6fyc6Sw3prDzOnaZmwv3ZfyOI4WnIC2XXZjejKz3aPwGA Tk08McKz6T2U0TlwEhtIyqjbecCYTxS1OPcpQhmYUSPzL9z1H29S6d5wnA1CWcFUqAYg 0bIeA9zP4BPsFHql89X4wx6TU3q7ydctWXUoMzRIy/lbXD+a+89DISPTfRAsIoH1c05d m37w== X-Forwarded-Encrypted: i=1; AKwUvBzqVN0CejkmkaMJ/rUaoZerWoTpDPMcHM/D8U5T8PU6KUIBBkYUiiWWxYb1j05X4PN2KAdGVhjzjrePJQ==@sourceware.org X-Gm-Message-State: AFq9FYK86CqITriYN221JlzT9hUQIBRjZkmnoEZNE1i+dNTOrHmYpPgt poeCNB2JDSGQNQkhE5idKyzK7q3Oju8JOChPTVQG7GuaipF560eRoVNFDRrgEzUXE/w= X-Gm-Gg: AYBFou1BR3M2/PnmCG2J93nE9ECoCigX67aYqnKo5TQM1iK8dvtIBmEZaWAndG6FF5E jULuFjDf57MwXMIKFt4iKLaiSMXeLiNpchAw85rHpA2D9CYHPUCkkzMuWXWB25cs7UZFg10LRUN Hx7KwO5CzdZVE9Op/mBECyEX1tDyS2nvNBn+73Ic4uq3AL/iP0zRHACdbpr30+NFnIdgsaxEG/C IzUrUvGgsI4oxZpQHC6TGv/6Qnw5FiZvrCF1hNAbwNIIRmFiRJpBd00J4yE3ajdPkT6yyfDRciW A+p0sEvPPCBMf5ZHb+yLvO1jeSVU7j+k6iDqi4RzGegsCiaeK1ihJTqjb/PqlsF9tACFR0aVb29 GXjjKW81cJX8nQaHgYE5/qW1FykH+mS+VuFURzxkS47e1WWMfLM46A9M0j1/4NnXVEaA/KKsSuh kx8eZiHRnxMprrFf/MOQrSo0lI9/sPYUv+gbxLhzcJwFR232B4aUbC43CkwYYSxd1YszH6xiR3Z pbxnHgyj1Af X-Received: by 2002:a05:6402:52c5:b0:6ab:e30:c9a7 with SMTP id 4fb4d7f45d1cf-6aff3902068mr4580705a12.10.1791462863521; Thu, 08 Oct 2026 05:34:23 -0700 (PDT) Received: from [192.168.0.192] ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b009e819ebsm1379534a12.9.2026.10.08.05.34.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2026 05:34:23 -0700 (PDT) Message-ID: <48cd6cef-8ecd-4bcc-85cf-25c821c2fae3@embecosm.com> Date: Thu, 8 Oct 2026 13:34:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add missing null pointer check in get_sal_arch From: Craig Blackmore To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Cook References: <20260729150617.3502554-1-craig.blackmore@embecosm.com> <87ik5vmdsi.fsf@redhat.com> <87fr0zmb79.fsf@redhat.com> <4ecef44c-61e1-4f20-ae9d-d177edd429e1@embecosm.com> Content-Language: en-US Autocrypt: addr=craig.blackmore@embecosm.com; keydata= xsBNBFdIF8oBCACwrsvc6YVfzJRT+ZoBfL9jEb8ITwNahDxCGSG6sIWrJ9UFeTwE8fnNhMpz RyFRm0OXruS5k/8YHJHrxKxFY9cgZ3CWNftXEjRqURUWGtN/ESiw0J7nVfhSGQTo3LBzpXZ1 0JHk4ZHKDJKYa+fhybCHOs19BfP3HydHoTlc5QTKMfom0X/xo7WDdwUYeZsjD9u8IzHk7gNw 05Abk1vqni+J7Fghjp4RI8W3IsjpKOfV3f02OyO/MTSraXNyejO4JRl0A8b3q1Lq+G6Z7o5n LVief5JpkRyzWQSawTIBKmRZa9EzAKZXd6IJdY/sZt7pTir5EP7MHq4a+AtKfKuDkrDDABEB AAHNLkNyYWlnIEJsYWNrbW9yZSA8Y3JhaWcuYmxhY2ttb3JlQGVtYmVjb3NtLmNvbT7CwHgE EwECACIFAldIF8oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGEeRQLLl5WtydMH /1nYd9jmOBaF8w5gGgjF5eOO5b/cdUegmO///VYj/5R7iF/zbB6KgF0Obo5h2gG9AIfsZG+T ybuTx7oU1DZYEIndw+YP9c9Yi5de5UzEHwbJiV57W0n+MP0Widgw7p6XJmUQ1XbHxdcWp7nY EJa8ASKLuuIhO8JFUXbQ8BcUiWbsA/JxgCzeid8iixGrzPWj6iFzoK2mX4GqP+24pXSDUamM TXmSQd2taYEsyUdJNiEkUC51ncRcMuThjdtfn6Ok+7lHjh3Zz8q0keJz5pnIp4EXdkAgKSjq U42PMrd3v1HoIFINTtr5F23OdkxoQzysu4GMO4pkw5pwz95Uckr08ojOwE0EV0gXygEIAKv/ luYHmCG/qefgzdbnegwMdG5753NJ+zGxFltFX6aaOPZ8go9Omf6zwjybUKv6Qx6AlDanwCl3 ewVQs+h9iW8uaQBRgeDmwAGMG/doBiFqs7X0jBf23exMiJezXlKb2ZlKzMAbzJ87408AzRaV sZdwEpXHVi2mRPoXtMrqL5iQEyG5hdx2ySj5164DIgVOs/ypFiaiFaDPkIcAQTzJrxsbt6pf iI9kT93DO9nRKVV0pPWztV8P5gKM8HY2rS0wQcfrqAU6T89Aa0VFw92J+w5d2spF8MUNPsvR NLm9ooCF3YME9STYHXrNH1U9fJUWpIC+b49UoWSWRD9nwl2h2i8AEQEAAcLAXwQYAQIACQUC V0gXygIbDAAKCRBhHkUCy5eVreLbB/sHPs1xu78uNV8O4UPTX7D5zBBS3nsrbDr+8stmXRap xbvo6kqKzIMAXuO3bYB/NyJ/tFzuFr9Tjd/2g56D2186bp01/kgxJ9CEl/m2T3lG3DlxIoLg pCExzTLTb8zH/7/6mdeJ17cdnrK+2QAKYctReVPAC67cq5KmUyU3bv5e1JzhV4ezz/i/O+Jv el112ZEsa54ya9KZOUHbgAR6hLnRWIa+8yQTtXqYRc3LxLRfS80Wn0Err1YvqFYzJsQMC8ND xAeEuqQ1gfk1b0jmv7tYljNqsHqzGVbuWz6hyzyLv5GjcdSDKpbw/797gRKQSY8Gty5ynfUH O4kKyuZPrE8P In-Reply-To: <4ecef44c-61e1-4f20-ae9d-d177edd429e1@embecosm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 21/08/2026 11:25, Craig Blackmore wrote: > > Thanks for looking into this and sharing your analysis and alternative > fix. I much prefer your fix as it addresses the root cause and it works > on both my original test and the updated test that I just posted. > > As you've written the fix, would you prefer to add my test to your patch > or for me to combine everything into a new submission? Hi Andrew, Did you have any thoughts on how you would like to proceed? Thanks, Craig