From: Denis PILAT <denis.pilat@st.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: "'gdb-patches'" <gdb-patches@sourceware.org>
Subject: Re: Mingw gdb validation
Date: Wed, 22 Oct 2008 13:05:00 -0000 [thread overview]
Message-ID: <48FF24D8.4080204@st.com> (raw)
In-Reply-To: <000001c9342a$189a83a0$49cf8ae0$@u-strasbg.fr>
Pierre Muller wrote:
> I thought about this a while ago also,
> and I was wondering if the best solution would not be to
> have a global nl variable defined in gdb.exp
> that would depend on the target you are testing.
> I also thought at that time that we should
> define two global variables: nl and nls.
> "nl" as being something that is a single newline
> defined generally as "\[\r\n\]" but probably as "\[\r\n\]\n?" for mingw32
> and
> "nls" if more than one newline is allowed and should generally be simply
> "\[\r\n\]*"
>
If it's more than one we should use "\[\r\n\]+".
> Once these two variables are set in gdb.exp,
> we should replace every "\[\r\n\]*" by a "$nls"
> and all \[\r\n\]" by "$nl" in the expected answer part of the tests.
>
>
> This should allow a lot of currently failing mingw32 test
> to succeed.
> It would also have the advantage of not changing
> anything for other targets, unless we find other targets that
> would benefit from a similar change, but that could then also
> be inserted in gdb.exp special cases for nl and nls variables.
>
> Nevertheless, changing all tests to use nl and nls
> is probably not an easy task...
>
That's just a long task, but I think it's easier than understanding why
some tests require end-of-line testing, and some tests do not. See my
previous mail about gdb.cp/userdef.exp.
I'm afraid there could be some tests that has been written to match the
gdb behavior, even if it was not a correct behavior.
Denis
next prev parent reply other threads:[~2008-10-22 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 8:41 Denis PILAT
2008-10-22 9:40 ` Pierre Muller
2008-10-22 13:05 ` Denis PILAT [this message]
2008-10-22 14:15 ` Pierre Muller
2008-10-22 13:27 ` Daniel Jacobowitz
2008-10-22 13:32 ` Pedro Alves
2008-10-22 13:38 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF24D8.4080204@st.com \
--to=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox