Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Mingw gdb validation
Date: Wed, 22 Oct 2008 13:27:00 -0000	[thread overview]
Message-ID: <20081022132606.GA9276@caradoc.them.org> (raw)
In-Reply-To: <48FC4417.2030807@st.com>

On Mon, Oct 20, 2008 at 10:40:55AM +0200, Denis PILAT wrote:
> Is there any chance for such a patch to be accepted ?
> It allows the following test to be successful when using a MinGW gdb  
> (means a gdb compiled under MSYS environment or using  
> CFLAGS="-mno-cygwin" under cygwin).

That depends why it's necessary... we have been testing mingw GDB
binaries for at least a year, and I've never seen this failure.
Are you using a Cygwin expect binary to drive the GDB?

> If yes I will write a correct changelog entry.
> The following $nl value is the only one that works both on linux and  
> windows when running a validation.
>
>
> About  gdb.cp/userdef.exp, I don't understand why only in part of the  
> tests we have a \r\n expected as the answer ?
> gdb_test "print one % two" "\\\$\[0-9\]* = {x = 2, y = 3}"
> gdb_test "print one && two" "\\\$\[0-9\]* = 1\[\r\n\]"    <===== Why  
> expecting \r\n here  and not above ?

I don't know either, there it can probably be removed.  It was
probably to ensure that there wasn't another character after the 1,
but gdb_test already does that.


-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2008-10-22 13:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  8:41 Denis PILAT
2008-10-22  9:40 ` Pierre Muller
2008-10-22 13:05   ` Denis PILAT
2008-10-22 14:15     ` Pierre Muller
2008-10-22 13:27 ` Daniel Jacobowitz [this message]
2008-10-22 13:32   ` Pedro Alves
2008-10-22 13:38   ` Denis PILAT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022132606.GA9276@caradoc.them.org \
    --to=drow@false.org \
    --cc=denis.pilat@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox