From: Stan Shebs <stanshebs@earthlink.net>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: Remove dead code, clear breakpoint ignore counts?
Date: Tue, 14 Oct 2008 18:33:00 -0000 [thread overview]
Message-ID: <48F4E5A0.6010602@earthlink.net> (raw)
In-Reply-To: <200810141910.49306.pedro@codesourcery.com>
Pedro Alves wrote:
> I think I stared at this one time too many.
>
> What do you think of the attached? Would anyone miss this? There's
> no way the user can request to not show hit counts, so, this is dead
> code.
>
Heh, I can't even remember why it seemed like there was any interest in
conditionalizing; perhaps because the hit counts were a new feature and
we thought users would want to be able to go back to the old behavior.
In any case, I think by now there is consensus that hit counts are good
to display. :-)
Hit counts are going to get a little messy for multi-process, because
each inferior could have a different hit count, and it seems more useful
to have a per-inferior hit count than an aggregate over all the
inferiors to which the breakpoint applies.
Stan
next prev parent reply other threads:[~2008-10-14 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 18:11 Pedro Alves
2008-10-14 18:33 ` Stan Shebs [this message]
2008-10-14 18:53 ` Pedro Alves
2008-10-14 20:10 ` Tom Tromey
2008-10-14 20:55 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F4E5A0.6010602@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox