From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30486 invoked by alias); 14 Oct 2008 18:33:08 -0000 Received: (qmail 30461 invoked by uid 22791); 14 Oct 2008 18:33:07 -0000 X-Spam-Check-By: sourceware.org Received: from elasmtp-dupuy.atl.sa.earthlink.net (HELO elasmtp-dupuy.atl.sa.earthlink.net) (209.86.89.62) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Oct 2008 18:32:28 +0000 Received: from [68.108.142.23] (helo=macbook-2.local) by elasmtp-dupuy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1Kpogq-0007nv-6l; Tue, 14 Oct 2008 14:32:16 -0400 Message-ID: <48F4E5A0.6010602@earthlink.net> Date: Tue, 14 Oct 2008 18:33:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: PATCH: Remove dead code, clear breakpoint ignore counts? References: <200810141910.49306.pedro@codesourcery.com> In-Reply-To: <200810141910.49306.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9404573e31664d3de042a023be398f6dda8350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00352.txt.bz2 Pedro Alves wrote: > I think I stared at this one time too many. > > What do you think of the attached? Would anyone miss this? There's > no way the user can request to not show hit counts, so, this is dead > code. > Heh, I can't even remember why it seemed like there was any interest in conditionalizing; perhaps because the hit counts were a new feature and we thought users would want to be able to go back to the old behavior. In any case, I think by now there is consensus that hit counts are good to display. :-) Hit counts are going to get a little messy for multi-process, because each inferior could have a different hit count, and it seems more useful to have a per-inferior hit count than an aggregate over all the inferiors to which the breakpoint applies. Stan