Re: [RFA] Reverse Debugging, 5/5

[Michael Snyder <msnyder@vmware.com>]

Joel Brobecker wrote:
> I think that the implementation of this file will change slightly based
> on the outcome of some of the discussions we had with the previous
> patch.  But I noticed a few little things in addition to what Eli
> already said.
> 
>> +   Copyright (C) 2006 Free Software Foundation, Inc.
> 
> The copyright date should include 2008.

OK

>> +   (returns error unles target implements to_set_execdir method).  */
>                      ^^^^^
>                      unless
>> +static void
>> +exec_reverse_once (char *cmd, char *args, int from_tty)
> 
> This function needs a comment describing what it does.  I was almost
> at the end of the function before I understood its purpose.

OK

>> +  add_setshow_enum_cmd ("exec-direction", class_run, exec_direction_names,
>> +                     &exec_direction, "Set direction of execution.\n\
>> +Options are 'forward' or 'reverse'.",
>> +                     "Show direction of execution (forward/reverse).",
>> +                     "Tells gdb whether to execute forward or backward.",
>> +                     set_exec_direction_func, show_exec_direction_func,
>> +                     &setlist, &showlist);
> 
> Minor nit: i18n.

OK