From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9180 invoked by alias); 7 Oct 2008 18:25:31 -0000 Received: (qmail 9159 invoked by uid 22791); 7 Oct 2008 18:25:29 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Oct 2008 18:24:54 +0000 Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id EE2273D009; Tue, 7 Oct 2008 11:24:52 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost5.vmware.com (Postfix) with ESMTP id E978BDC061; Tue, 7 Oct 2008 11:24:52 -0700 (PDT) Message-ID: <48EBA8FE.7030700@vmware.com> Date: Tue, 07 Oct 2008 18:25:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Daniel Jacobowitz , Pedro Alves , teawater Subject: Re: [RFA] Reverse Debugging, 5/5 References: <48E3CD66.9020600@vmware.com> <20081007032955.GC28138@adacore.com> In-Reply-To: <20081007032955.GC28138@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00218.txt.bz2 Joel Brobecker wrote: > I think that the implementation of this file will change slightly based > on the outcome of some of the discussions we had with the previous > patch. But I noticed a few little things in addition to what Eli > already said. > >> + Copyright (C) 2006 Free Software Foundation, Inc. > > The copyright date should include 2008. OK >> + (returns error unles target implements to_set_execdir method). */ > ^^^^^ > unless >> +static void >> +exec_reverse_once (char *cmd, char *args, int from_tty) > > This function needs a comment describing what it does. I was almost > at the end of the function before I understood its purpose. OK >> + add_setshow_enum_cmd ("exec-direction", class_run, exec_direction_names, >> + &exec_direction, "Set direction of execution.\n\ >> +Options are 'forward' or 'reverse'.", >> + "Show direction of execution (forward/reverse).", >> + "Tells gdb whether to execute forward or backward.", >> + set_exec_direction_func, show_exec_direction_func, >> + &setlist, &showlist); > > Minor nit: i18n. OK