From: Michael Snyder <msnyder@vmware.com>
To: "tromey@redhat.com" <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Daniel Jacobowitz <drow@false.org>,
Pedro Alves <pedro@codesourcery.com>,
teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 4/5
Date: Mon, 06 Oct 2008 22:55:00 -0000 [thread overview]
Message-ID: <48EA96E6.40504@vmware.com> (raw)
In-Reply-To: <m3vdw58i8g.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>
> Michael> +void
> Michael> +breakpoint_silence (struct breakpoint *b)
> Michael> +{
> Michael> + /* Silence the breakpoint. */
> Michael> + b->silent = 1;
>
> Joel> Minor nit: This name brings little meaning when I see it being called.
> Joel> Can we change it to "make_breakpoint_silent"? That way, the comment
> Joel> in the body becomes useless and can be removed.
>
> The Python breakpoint wrapper directly sets or clears b->silent.
> Perhaps we could make this a generic setter in anticipation of that
> patch?
Erm, yeah, I started to say "I'm open to it", but
hey, I just want to get my patch in! Surely it will
be easy enough to change this to a generic setter
later?
next prev parent reply other threads:[~2008-10-06 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 19:21 Michael Snyder
2008-10-06 21:27 ` Pedro Alves
2008-10-06 21:50 ` Michael Snyder
2008-10-06 21:57 ` Joel Brobecker
2008-10-06 22:18 ` Michael Snyder
2008-10-07 3:18 ` Joel Brobecker
2008-10-06 22:42 ` Tom Tromey
2008-10-06 22:55 ` Michael Snyder [this message]
2008-10-06 22:59 ` Tom Tromey
2008-10-07 3:15 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EA96E6.40504@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox