From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59071-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10891 invoked by alias); 6 Oct 2008 22:55:54 -0000
Received: (qmail 10881 invoked by uid 22791); 6 Oct 2008 22:55:54 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Oct 2008 22:55:19 +0000
Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 7C50467CD; 	Mon,  6 Oct 2008 15:55:16 -0700 (PDT)
Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) 	by mailhost5.vmware.com (Postfix) with ESMTP id DE9D9DC08D; 	Mon,  6 Oct 2008 15:55:16 -0700 (PDT)
Message-ID: <48EA96E6.40504@vmware.com>
Date: Mon, 06 Oct 2008 22:55:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: "tromey@redhat.com" <tromey@redhat.com>
CC: Joel Brobecker <brobecker@adacore.com>,   "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Daniel Jacobowitz <drow@false.org>, Pedro Alves <pedro@codesourcery.com>,   teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 4/5
References: <48E3CD40.3070206@vmware.com> <20081006215637.GE21853@adacore.com> <m3vdw58i8g.fsf@fleche.redhat.com>
In-Reply-To: <m3vdw58i8g.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00187.txt.bz2

Tom Tromey wrote:
>>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> 
> Michael> +void
> Michael> +breakpoint_silence (struct breakpoint *b)
> Michael> +{
> Michael> +  /* Silence the breakpoint.  */
> Michael> +  b->silent = 1;
> 
> Joel> Minor nit: This name brings little meaning when I see it being called.
> Joel> Can we change it to "make_breakpoint_silent"?  That way, the comment
> Joel> in the body becomes useless and can be removed.
> 
> The Python breakpoint wrapper directly sets or clears b->silent.
> Perhaps we could make this a generic setter in anticipation of that
> patch?

Erm, yeah, I started to say "I'm open to it", but
hey, I just want to get my patch in!  Surely it will
be easy enough to change this to a generic setter
later?