From: Michael Snyder <msnyder@vmware.com>
To: Michael Snyder <msnyder@specifix.com>,
angela@releasedominatrix.com, gdb-patches@sourceware.org
Subject: Re: patch to send telnet BREAK for remote-over-tcp
Date: Wed, 03 Sep 2008 17:13:00 -0000 [thread overview]
Message-ID: <48BEC576.3010802@vmware.com> (raw)
In-Reply-To: <20080903131207.GA8151@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Tue, Sep 02, 2008 at 09:35:29PM -0700, Michael Snyder wrote:
>> I think this looks right, but I'd love to get another opinion.
>>
>> Daniel? Anybody?
>
> It seems fine (aside from the parenthesis formatting :-P), though I
> think it would be much more useful if added to the manual.
OK, since I don't know if Angela has write privs, I'll fix
the parens and check it in later today.
Should this change be propagated to ser-mingw.c? It shares
some code with this module but makes up its own serial_ops
struct.
If not, I'll just make the new function a static, shall I?
next prev parent reply other threads:[~2008-09-03 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 22:53 Angela Marie Thomas
2008-09-03 4:36 ` Michael Snyder
2008-09-03 13:12 ` Daniel Jacobowitz
2008-09-03 17:13 ` Michael Snyder [this message]
2008-09-03 17:30 ` Daniel Jacobowitz
2008-09-03 20:29 ` Michael Snyder
2008-09-03 20:41 ` Eli Zaretskii
2008-09-03 23:55 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BEC576.3010802@vmware.com \
--to=msnyder@vmware.com \
--cc=angela@releasedominatrix.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@specifix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox