From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20722 invoked by alias); 3 Sep 2008 17:13:16 -0000 Received: (qmail 20707 invoked by uid 22791); 3 Sep 2008 17:13:15 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 Sep 2008 17:12:34 +0000 Received: from mailhost5.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 9050E6978; Wed, 3 Sep 2008 10:12:32 -0700 (PDT) Received: from [10.20.92.218] (promb-2s-dhcp218.eng.vmware.com [10.20.92.218]) by mailhost5.vmware.com (Postfix) with ESMTP id 7ACD8DC081; Wed, 3 Sep 2008 10:12:32 -0700 (PDT) Message-ID: <48BEC576.3010802@vmware.com> Date: Wed, 03 Sep 2008 17:13:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Michael Snyder , angela@releasedominatrix.com, gdb-patches@sourceware.org Subject: Re: patch to send telnet BREAK for remote-over-tcp References: <20080829225247.92696FE88A@dzur.releasedominatrix.com> <1220416529.3389.2.camel@localhost.localdomain> <20080903131207.GA8151@caradoc.them.org> In-Reply-To: <20080903131207.GA8151@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00047.txt.bz2 Daniel Jacobowitz wrote: > On Tue, Sep 02, 2008 at 09:35:29PM -0700, Michael Snyder wrote: >> I think this looks right, but I'd love to get another opinion. >> >> Daniel? Anybody? > > It seems fine (aside from the parenthesis formatting :-P), though I > think it would be much more useful if added to the manual. OK, since I don't know if Angela has write privs, I'll fix the parens and check it in later today. Should this change be propagated to ser-mingw.c? It shares some code with this module but makes up its own serial_ops struct. If not, I'll just make the new function a static, shall I?