Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Patch to imported readline to allow DJGPP build
Date: Tue, 30 Dec 2003 06:16:00 -0000	[thread overview]
Message-ID: <4839-Tue30Dec2003081408+0200-eliz@elta.co.il> (raw)
In-Reply-To: <16368.43916.468843.207711@localhost.redhat.com> (message from Elena Zannoni on Mon, 29 Dec 2003 17:32:44 -0500)

> From: Elena Zannoni <ezannoni@redhat.com>
> Date: Mon, 29 Dec 2003 17:32:44 -0500
> 
> I remember having exchanged some mail with Chet and you about this,
> but I don't remember the outcome. I can't find anything in my old mbox
> either.  The readline in our tree includes some patches on top of pure
> 4.3.  One of the patches is this one, which I kept from the previous
> version:
> 
> 2000-07-10  Eli Zaretskii  <eliz@is.elta.co.il>

Oh, I see now: you've patched readline 4.3 with my patches from an
older version.

> Other changes are those listed in ChangeLog.gdb. You can do a diff
> with a pristine 4.3 readline.

I did both, but still couldn't figure out the issue, since there were
clearly changes that didn't come from any of these two sources.

> There are some other local changes that I keep integrating at each
> import.  I should probably have specified that in the changelog
> entry at the time.

Yes, a good idea, IMHO.

> You changes are OK.

Thanks, I will commit them shortly.

> I think you should audit the current diffs, though, to see if they
> are all still needed for DJGPP.

I did that, and they are.

(There was a plan to have a termcap library for DJGPP that would
eliminate the need for those ugly hacks, but I don't have time to
carry it over, not just yet.)

> On top of that there are some 'official' patches that are advertised
> on the readline home page, which I have not merged. 

Looked at those as well as part of my attempts to understand what
happened.  AFAICS, some of those patches (or their close equivalents)
are already in GDB's repository.

Thanks again.


  reply	other threads:[~2003-12-30  6:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-29  8:03 Eli Zaretskii
2003-12-29 22:32 ` Elena Zannoni
2003-12-30  6:16   ` Eli Zaretskii [this message]
2004-01-15 19:03     ` Elena Zannoni
2004-01-17 18:27       ` Eli Zaretskii
2003-12-30  7:26   ` Eli Zaretskii
2003-12-29 19:57 Michael Elizabeth Chastain
2003-12-29 21:48 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4839-Tue30Dec2003081408+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox