From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32064 invoked by alias); 30 Dec 2003 06:16:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32057 invoked from network); 30 Dec 2003 06:16:39 -0000 Received: from unknown (HELO bilbo.inter.net.il) (192.114.186.18) by sources.redhat.com with SMTP; 30 Dec 2003 06:16:39 -0000 Received: from zaretski (pns03-195-8.inter.net.il [80.230.195.8]) by bilbo.inter.net.il (Mirapoint Messaging Server MOS 3.3.8-GR) with ESMTP id CDK92877; Tue, 30 Dec 2003 08:16:28 +0200 (IST) Date: Tue, 30 Dec 2003 06:16:00 -0000 From: "Eli Zaretskii" To: Elena Zannoni Message-Id: <4839-Tue30Dec2003081408+0200-eliz@elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <16368.43916.468843.207711@localhost.redhat.com> (message from Elena Zannoni on Mon, 29 Dec 2003 17:32:44 -0500) Subject: Re: [RFA] Patch to imported readline to allow DJGPP build Reply-to: Eli Zaretskii References: <7137-Mon29Dec2003100055+0200-eliz@elta.co.il> <16368.43916.468843.207711@localhost.redhat.com> X-SW-Source: 2003-12/txt/msg00515.txt.bz2 > From: Elena Zannoni > Date: Mon, 29 Dec 2003 17:32:44 -0500 > > I remember having exchanged some mail with Chet and you about this, > but I don't remember the outcome. I can't find anything in my old mbox > either. The readline in our tree includes some patches on top of pure > 4.3. One of the patches is this one, which I kept from the previous > version: > > 2000-07-10 Eli Zaretskii Oh, I see now: you've patched readline 4.3 with my patches from an older version. > Other changes are those listed in ChangeLog.gdb. You can do a diff > with a pristine 4.3 readline. I did both, but still couldn't figure out the issue, since there were clearly changes that didn't come from any of these two sources. > There are some other local changes that I keep integrating at each > import. I should probably have specified that in the changelog > entry at the time. Yes, a good idea, IMHO. > You changes are OK. Thanks, I will commit them shortly. > I think you should audit the current diffs, though, to see if they > are all still needed for DJGPP. I did that, and they are. (There was a plan to have a termcap library for DJGPP that would eliminate the need for those ugly hacks, but I don't have time to carry it over, not just yet.) > On top of that there are some 'official' patches that are advertised > on the readline home page, which I have not merged. Looked at those as well as part of my attempts to understand what happened. AFAICS, some of those patches (or their close equivalents) are already in GDB's repository. Thanks again.