From: Markus Deuling <deuling@de.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch]: Add endianess to valprint routines
Date: Fri, 23 May 2008 16:32:00 -0000 [thread overview]
Message-ID: <4836480F.6050604@de.ibm.com> (raw)
In-Reply-To: <200805211514.m4LFEW6N002120@d12av02.megacenter.de.ibm.com>
Hi Uli,
Ulrich Weigand schrieb:
> Markus Deuling wrote:
>
>> * valprint.c (print_hex_chars, print_octal_chars, print_decimal_chars,
>> print_binary_chars, print_char_chars): Add byte_order parameter and
>> replace gdbarch_byte_order.
>> (print_decimal_chars): Replace START_P, NOT_END_P and NEXT_P by their
>> expressions and remove them. Remove unused TWO_TO_FOURTH.
>> (val_print_type_code_int): Introduce gdbarch_byte_order to get at the
>> endianness. Update call to print_hex_chars.
>> * valprint.h (print_hex_chars, print_octal_chars, print_decimal_chars,
>> print_binary_chars, print_char_chars): Add byte_order parameter.
>> * printcmd.c (print_scalar_formatted): Introduce gdbarch_byte_order to
>> get at the endianness. Update print_*_char calls to use byte_order.
>
> Minor coding style issue in the ChangeLog: please always use two spaces
> after '.'.
>
> Otherwise, this is OK.
>
> Thanks,
> Ulrich
>
thank you. Committed with a reworked ChangeLog.
Regards,
Markus
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
prev parent reply other threads:[~2008-05-23 4:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 15:19 Markus Deuling
2008-05-20 17:48 ` Ulrich Weigand
2008-05-21 16:45 ` Markus Deuling
2008-05-21 18:35 ` Ulrich Weigand
2008-05-23 16:32 ` Markus Deuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4836480F.6050604@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox