From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21092 invoked by alias); 23 May 2008 04:30:45 -0000 Received: (qmail 21084 invoked by uid 22791); 23 May 2008 04:30:44 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 23 May 2008 04:30:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m4N4T4qR020368 for ; Fri, 23 May 2008 04:29:04 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4N4T5eS3285222 for ; Fri, 23 May 2008 06:29:05 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4N4T47N005312 for ; Fri, 23 May 2008 06:29:05 +0200 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m4N4T30f005307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 May 2008 06:29:04 +0200 Message-ID: <4836480F.6050604@de.ibm.com> Date: Fri, 23 May 2008 16:32:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Ulrich Weigand CC: GDB Patches Subject: Re: [patch]: Add endianess to valprint routines References: <200805211514.m4LFEW6N002120@d12av02.megacenter.de.ibm.com> In-Reply-To: <200805211514.m4LFEW6N002120@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00676.txt.bz2 Hi Uli, Ulrich Weigand schrieb: > Markus Deuling wrote: > >> * valprint.c (print_hex_chars, print_octal_chars, print_decimal_chars, >> print_binary_chars, print_char_chars): Add byte_order parameter and >> replace gdbarch_byte_order. >> (print_decimal_chars): Replace START_P, NOT_END_P and NEXT_P by their >> expressions and remove them. Remove unused TWO_TO_FOURTH. >> (val_print_type_code_int): Introduce gdbarch_byte_order to get at the >> endianness. Update call to print_hex_chars. >> * valprint.h (print_hex_chars, print_octal_chars, print_decimal_chars, >> print_binary_chars, print_char_chars): Add byte_order parameter. >> * printcmd.c (print_scalar_formatted): Introduce gdbarch_byte_order to >> get at the endianness. Update print_*_char calls to use byte_order. > > Minor coding style issue in the ChangeLog: please always use two spaces > after '.'. > > Otherwise, this is OK. > > Thanks, > Ulrich > thank you. Committed with a reworked ChangeLog. Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com