Re: [RFC] gdb.mi tests

[Aleksandar Ristovski <ARistovski@qnx.com>]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

Daniel Jacobowitz wrote:
> On Wed, Mar 12, 2008 at 03:18:15PM -0400, Aleksandar Ristovski wrote:
>> Attached working diff. Comments welcome.
> 
> I think this patch is OK, if you add a changelog entry for it.  Do
> you have write access?  If not, would you like to?
> 

In the context of this thread, I have reduced the originally proposed diff.
Now 
it is a simple change in mi-support.exp, diff attached.

I gave up the removal of "load_lib mi-support.exp" from all tests since, as 
Daniel pointed out, the overriding can still be done by loading the file in
your 
board file, and after the load_lib statement redefining the functions of 
interest; load_lib makes sure to not reload already loaded file.

Leaving "load_lib mi-support.exp" maybe makes it a bit more clear what file 
contains functions that can be overridden.

Thanks,

Aleksandar Ristovski
QNX Software Systems



2008-03-28  Aleksandar Ristovski  <aristovski@qnx.com>

	* lib/mi-support.exp: Rename mi_gdb_start to default_mi_gdb_start
and
	add mi_gdb_start to simply call the default one. Brings mi-support
	in line with gdb.exp.



[-- Attachment #2: mi-support.diff --]
[-- Type: text/plain, Size: 1492 bytes --]

Index: gdb/testsuite/lib/mi-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
retrieving revision 1.51
diff -u -p -r1.51 mi-support.exp
--- gdb/testsuite/lib/mi-support.exp	29 Jan 2008 19:36:58 -0000	1.51
+++ gdb/testsuite/lib/mi-support.exp	28 Mar 2008 15:07:52 -0000
@@ -84,7 +84,7 @@ proc mi_uncatched_gdb_exit {} {
 }
 
 #
-# mi_gdb_start [INFERIOR_PTY] -- start gdb running, default procedure
+# default_mi_gdb_start [INFERIOR_PTY] -- start gdb running, default procedure
 #
 # INFERIOR_PTY should be set to separate-inferior-tty to have the inferior work 
 # with it's own PTY. If set to same-inferior-tty, the inferior shares GDB's PTY. 
@@ -94,7 +94,7 @@ proc mi_uncatched_gdb_exit {} {
 # tests on different hosts all using the same server, things can
 # get really slow.  Give gdb at least 3 minutes to start up.
 #
-proc mi_gdb_start { args } {
+proc default_mi_gdb_start { args } {
     global verbose
     global GDB
     global GDBFLAGS
@@ -230,6 +230,14 @@ proc mi_gdb_start { args } {
     return 0;
 }
 
+#
+# Overridable function. You can override this function in your
+# baseboard file.
+# 
+proc mi_gdb_start { args } {
+  return [default_mi_gdb_start $args]
+}
+
 # Many of the tests depend on setting breakpoints at various places and
 # running until that breakpoint is reached.  At times, we want to start
 # with a clean-slate with respect to breakpoints, so this utility proc