[patch] Avoid null ptr dereference in maint cplus first_component

[patch] Avoid null ptr dereference in maint cplus first_component

[Aleksandar Ristovski]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hello,

A trivial patch to avoid segemtation fault when no argument is supplied to 
'maint cplus first_component' command.

Thanks,

---
Aleksandar Ristovski
QNX Software Systems


2008-03-19  Aleksandar Ristovski <aristovski@qnx.com>

	* cp-support.c (first_component_command): Return if no arguments.




[-- Attachment #2: cp-support.c.diff --]
[-- Type: text/plain, Size: 686 bytes --]

Index: gdb/cp-support.c
===================================================================
RCS file: /cvs/src/src/gdb/cp-support.c,v
retrieving revision 1.26
diff -u -p -r1.26 cp-support.c
--- gdb/cp-support.c	1 Jan 2008 22:53:09 -0000	1.26
+++ gdb/cp-support.c	19 Mar 2008 19:07:54 -0000
@@ -892,8 +892,14 @@ maint_cplus_command (char *arg, int from
 static void
 first_component_command (char *arg, int from_tty)
 {
-  int len = cp_find_first_component (arg);
-  char *prefix = alloca (len + 1);
+  int len;  
+  char *prefix; 
+
+  if (!arg)
+    return;
+
+  len = cp_find_first_component (arg);
+  prefix = alloca (len + 1);
 
   memcpy (prefix, arg, len);
   prefix[len] = '\0';

Re: [patch] Avoid null ptr dereference in maint cplus first_component

[Daniel Jacobowitz]

On Wed, Mar 19, 2008 at 03:13:23PM -0400, Aleksandar Ristovski wrote:
> 2008-03-19  Aleksandar Ristovski <aristovski@qnx.com>
> 
> 	* cp-support.c (first_component_command): Return if no arguments.

OK, thanks.  Did I already ask you about write access?

-- 
Daniel Jacobowitz
CodeSourcery