Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: Michael Snyder <msnyder@specifix.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	        Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [patch] Fix fortran access to special register on SPU arch
Date: Mon, 03 Mar 2008 20:22:00 -0000	[thread overview]
Message-ID: <47CC5DCB.6040604@de.ibm.com> (raw)
In-Reply-To: <1204575007.19253.573.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi Michael,

Michael Snyder schrieb:
> I understand the failure mode (not located in memory), but
> if value_subscript works in the register case, why wouldn't
> it work in general, rather than value_ind?
> 

it does. Attached patch works fine. Ok ?



-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


[-- Attachment #2: diff-fortran --]
[-- Type: text/plain, Size: 446 bytes --]

diff -urpN src/gdb/eval.c dev/gdb/eval.c
--- src/gdb/eval.c	2008-02-11 05:48:36.000000000 +0100
+++ dev/gdb/eval.c	2008-03-03 21:19:32.000000000 +0100
@@ -1720,7 +1720,7 @@ evaluate_subexp_standard (struct type *e
 	   returns the correct type value */
 
 	deprecated_set_value_type (arg1, tmp_type);
-	return value_ind (value_add (value_coerce_array (arg1), arg2));
+	return value_subscript (arg1, arg2);
       }
 
     case BINOP_LOGICAL_AND:

      reply	other threads:[~2008-03-03 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03 19:07 Markus Deuling
2008-03-03 20:10 ` Michael Snyder
2008-03-03 20:22   ` Markus Deuling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CC5DCB.6040604@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@specifix.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox