Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, dje@google.com
Subject: Re: Re: [rfc] Use substitute-path for filename portion too
Date: Thu, 07 Feb 2008 18:51:00 -0000	[thread overview]
Message-ID: <47AB5332.5010805@qnx.com> (raw)
In-Reply-To: <20080207182754.GC3907@adacore.com>

Joel Brobecker wrote:
>>> Do we want to restrict this to filenames that are absolute paths?
>>> Imagine the filename was codesourcery/bar/bar.h and the rewrite was
>>> s/codesourcery/adacore/, do we want to attempt the rewrite then?
>>> I suppose we should wait to see a real example of such a situation
>>> before trying to support it...
>> Are such rules supported?  I couldn't work out from the manual
>> what FROM and TO had to be.
> 
> Yes, the documentation is not completely clear on this. After re-reading
> it, I think it seems to suggest that rewriting is done on the full path,
> not partial path names. Thinking about supporting it or not, I couldn't
> really come up with an answer. It seems that it could be surprising
> either way - which is why waiting for real-case scenarios would probably
> make sense here (and apply the patch as you and Doug suggested).
> 
> 
Yes, the patch is good, and it should be on absolute paths only.


  reply	other threads:[~2008-02-07 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 17:47 Daniel Jacobowitz
2008-02-07 17:57 ` Joel Brobecker
2008-02-07 18:14   ` Daniel Jacobowitz
2008-02-07 18:28     ` Joel Brobecker
2008-02-07 18:51       ` Aleksandar Ristovski [this message]
2008-02-08 15:02       ` Eli Zaretskii
2008-02-08  0:31     ` Doug Evans
2008-02-08 22:20       ` Daniel Jacobowitz
2008-02-08 22:21 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AB5332.5010805@qnx.com \
    --to=aristovski@qnx.com \
    --cc=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox