From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org, dje@google.com
Subject: Re: [rfc] Use substitute-path for filename portion too
Date: Thu, 07 Feb 2008 17:57:00 -0000 [thread overview]
Message-ID: <20080207175658.GB3907@adacore.com> (raw)
In-Reply-To: <20080207174645.GA19452@caradoc.them.org>
> 2008-02-07 Doug Evans <dje@google.com>
>
> * source.c (find_and_open_source): Always rewrite absolute filenames.
No problem from my end.
> +
> + if (IS_ABSOLUTE_PATH (filename))
> {
> - /* If dirname is NULL, chances are the path is embedded in
> - the filename. Try the source path substitution on it. */
> + /* If filename is absolute path, try the source path
> + substitution on it. */
Do we want to restrict this to filenames that are absolute paths?
Imagine the filename was codesourcery/bar/bar.h and the rewrite was
s/codesourcery/adacore/, do we want to attempt the rewrite then?
I suppose we should wait to see a real example of such a situation
before trying to support it...
--
Joel
next prev parent reply other threads:[~2008-02-07 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 17:47 Daniel Jacobowitz
2008-02-07 17:57 ` Joel Brobecker [this message]
2008-02-07 18:14 ` Daniel Jacobowitz
2008-02-07 18:28 ` Joel Brobecker
2008-02-07 18:51 ` Aleksandar Ristovski
2008-02-08 15:02 ` Eli Zaretskii
2008-02-08 0:31 ` Doug Evans
2008-02-08 22:20 ` Daniel Jacobowitz
2008-02-08 22:21 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207175658.GB3907@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox