Re: [PATCH v1] gdb/aarch64: Add support for FEAT_S1POE POR_EL0 register

[Luis <luis.machado.foss@gmail.com>]

On 18/06/2026 18:04, Matthieu Longo wrote:
>> +  user_poe user_poe;
>> +  iovec iovec;
>> +
>> +  iovec.iov_base = &user_poe;
>> +  iovec.iov_len = sizeof (user_poe);
>> +
>> +  int tid = get_ptrace_pid (regcache->ptid ());
> 
> * Question for maintainers: *
> 
> It seems that there are different methods to get the thread ID.
> I observed in the same file 3 different ways:
> - int tid = get_ptrace_pid (inferior_ptid);
> - int tid = regcache->ptid ().lwp ();
> - int tid = get_ptrace_pid (regcache->ptid ());
> 
> What is the "correct" method ?
> 

get_ptrace_pid here.

> 
> * Question for maintainers: *
> 
> All the architectural tests are already in the same directory, so moving 
> them inside subdirectories (one per architecture) is out of scope of 
> this patch.
> However, would it make sense to do it in a separate patch ?
> This directory starts getting very messy.
> 

Seems like a worthwhile refactor, but I'm not sure off the top of my 
head how the current makefile infra will handle it. If we decide to run 
gdb.arch tests, will it run gdb.arch/aarch64/*.exp?

I'm all for keeping things clean, but it needs to make it simple as well.

Thanks for the reviews by the way.