From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IRvKJffLN2owBRIAWB0awg (envelope-from ) for ; Sun, 21 Jun 2026 07:33:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Ssql4jG/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8B3471E098; Sun, 21 Jun 2026 07:33:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE08A1E024 for ; Sun, 21 Jun 2026 07:33:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84F584BA2E22 for ; Sun, 21 Jun 2026 11:33:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84F584BA2E22 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Ssql4jG/ Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 2088F4BA2E0D for ; Sun, 21 Jun 2026 11:32:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2088F4BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2088F4BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782041564; cv=none; b=Rw4GwD17mlhNzeEIZFvMsinUErry58T393JcsWqfnOf5FPrXba/3WCp5o9BsjZ2RCqw5/+xje+mMP2ZZmfCCzvyZg0Alp5XvnS3NWKA92YS1do1BpgAEbN907OdSBWotCHxhRGOnkUDmOgajXAA56HLZ1PSji6jizfnRN0mzxkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782041564; c=relaxed/simple; bh=SadP5EfbDlToGiGRg9Xg0J33BOaChcMMBeVYWktBi8U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fFD4OvR7v48+LWbxQnxlNO4vW8eFzHOSYlasA+Zgl2bDHV8L6f3P3O8UVMShVjA9A05d8f+X7kHOLAKF8eXxs61yjKlT97aDWWzgm2CPahGrzmY22BfCWDfwU5ptaBq1SnX4y+di4StjvMWZ2G7dNB5RQWXboAO0TSmYCOCxv7U= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Ssql4jG/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2088F4BA2E0D Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4908b92904fso48275165e9.0 for ; Sun, 21 Jun 2026 04:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782041563; x=1782646363; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kRe/t2xTm3ajcDxPy4lECue4n40R8dTooVeJlqjIDIE=; b=Ssql4jG/H9cSfONEKABupVGJa5icJBC9hbSTsNHksSCxD9PyDJiHM79GvbrMYRYA0P aPsISGde3H0sRl2iKyo+o1gc61owudwgQY8VUAjcJvjiRWDDaYcUHWvERdv60fMqPcWF 2ZcIE2tYcSNHaWI8nGKNdmwtVXdKN6p6mMJ7DuC2AKxagbdCYPnHtgyciAxAMeZvEZ+5 qmG38x3q10O7poiCpVDpwpkRmmHjALP/s4SCavHG5H+k4Z3DSm8Tn5Sy1clTgXvXeaWf QixUJK7dHWlczZRICdreA8k3sD6GrjpDZ51y4LASJMM6TPZqE3ur8b+ZSE47BeCeueY9 1//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782041563; x=1782646363; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kRe/t2xTm3ajcDxPy4lECue4n40R8dTooVeJlqjIDIE=; b=bc2l8BZv6rHDttu3RXDQPKfBLwsRc1mdXv1JY1THSUkggCAjnpd/kKIFUD4kE0bUQB NYGRpLgVcY/uiG5ID6fgkqKh72H9qveFmqdnZsxQ/bQfehvngiePITmItmQZW+ZCFzri kLnwIi1Gm/s0ULzYqE5x2PcPoRqwwvQ7LNx172alPwg7nGDKtQdrVq/aZMvS9tzHWWou IHyjA4KZT6eZyuoU3quYl7IFXdUbmq97qXyQomOIq35kGFpKi/NZ1NXxMiuhuBoqowhg GOv+6GohvOSyD/8NkQ48IsDjWYaY7KNiOJpp+PcUrgqwcPKYUbVaCU6sy1tjGYw33RAG yQUg== X-Forwarded-Encrypted: i=1; AFNElJ//0d+VQbEf4sUX8Jf30KTfaihZ3xEhygVfIQXcKTd9EMB+upFV0gJN+uu0qfmjAAVWglllEXyHEgPcuw==@sourceware.org X-Gm-Message-State: AOJu0Yzh2aFaog92U2C3KIisfwshRQpXlPQWYkPx7lt0dnhgFu/LY6G+ nOT5MwF6icbIH22NYqmv2wQn26Q46f+c4P4k2Ht7oo8MskZkrKvvuOfN X-Gm-Gg: AfdE7ckPigo9VtF8kizgiCKqwSEVMIASE0dAgVjTw4b5A5jViyeGTZoIFtglviBZNEN iDlGnuadJG1h5wLEPCyORFEiM2YFitaA2YMsMwKzdRo0Eq9/r02DBekn7PY3i2Q2kfpQTtiuxP1 rL21KBwp6T7Ac2Z1mZILkUg90rs4G0HZ1KAbIMbwLyiLQHkcz4eHOtWhKyxMLwS7phHPT/Hux2s RyORPc78wiVyxl1zRbn8Oft5bFPLoi+4GA4weDwilf0EupM5rLEgrDYE46OGzQtBN0uvavzztSP Cb2jV1YJOPWTc1hjY3je2Vwqw8EuhzzQw8cKU/irdIG5TKTE2/NP+rG/4cXbejF9lPX508yOvLb hVDHc3awc2AlovWDOG0ABWxeDl3el/4PiyGhu0PmwPz1kF9ScufuwlH23CG4bN7ea/W/G9SW2aN DpyiYxAV925wpB1B5+p8fu8fj33Q== X-Received: by 2002:a05:600c:b8d:b0:490:9588:bdb6 with SMTP id 5b1f17b1804b1-4924258f73amr133569105e9.33.1782041562724; Sun, 21 Jun 2026 04:32:42 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57a0esm15061220f8f.27.2026.06.21.04.32.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2026 04:32:41 -0700 (PDT) Message-ID: <47582751-6fc5-47f3-8799-2db6dd2809a1@gmail.com> Date: Sun, 21 Jun 2026 12:32:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] gdb/aarch64: Add support for FEAT_S1POE POR_EL0 register Content-Language: en-US To: Matthieu Longo , srinath.parvathaneni@arm.com, gdb-patches@sourceware.org Cc: guinevere@redhat.com, thiago.bauermann@linaro.org References: <20260617170003.1351479-1-srinath.parvathaneni@arm.com> <1d26b2c8-d8d1-486f-b2fc-8bd2ca1f2d05@arm.com> From: Luis In-Reply-To: <1d26b2c8-d8d1-486f-b2fc-8bd2ca1f2d05@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 18/06/2026 18:04, Matthieu Longo wrote: >> +  user_poe user_poe; >> +  iovec iovec; >> + >> +  iovec.iov_base = &user_poe; >> +  iovec.iov_len = sizeof (user_poe); >> + >> +  int tid = get_ptrace_pid (regcache->ptid ()); > > * Question for maintainers: * > > It seems that there are different methods to get the thread ID. > I observed in the same file 3 different ways: > - int tid = get_ptrace_pid (inferior_ptid); > - int tid = regcache->ptid ().lwp (); > - int tid = get_ptrace_pid (regcache->ptid ()); > > What is the "correct" method ? > get_ptrace_pid here. > > * Question for maintainers: * > > All the architectural tests are already in the same directory, so moving > them inside subdirectories (one per architecture) is out of scope of > this patch. > However, would it make sense to do it in a separate patch ? > This directory starts getting very messy. > Seems like a worthwhile refactor, but I'm not sure off the top of my head how the current makefile infra will handle it. If we decide to run gdb.arch tests, will it run gdb.arch/aarch64/*.exp? I'm all for keeping things clean, but it needs to make it simple as well. Thanks for the reviews by the way.