From: Pedro Alves <pedro_alves@portugalmail.pt>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: COMMIT: addrmap changes
Date: Wed, 05 Dec 2007 22:55:00 -0000 [thread overview]
Message-ID: <47572BDD.2090803@portugalmail.pt> (raw)
In-Reply-To: <m3wsruja90.fsf@codesourcery.com>
Hi Jim,
Jim Blandy wrote:
> I've committed the following, approved in another thread.
>
From the thread you've posted this first, I understood this
was work in progress, so most likelly you're already addressing
a few of these issues, but in case they slip through:
- GDB sources are now GPL v3
- I believe we're not allowed to use c99 features yet
(designated initializers in addrmap_fixed_funcs).
and being picky:
- suspicious call to abort, should be gdb_assert, or
internal_error ?
- #if 1
--
Pedro Alves
next prev parent reply other threads:[~2007-12-05 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 23:44 Jim Blandy
2007-12-05 1:41 ` Daniel Jacobowitz
2007-12-05 21:34 ` Jim Blandy
2007-12-06 4:35 ` Eli Zaretskii
2007-12-06 17:26 ` Jim Blandy
2007-12-05 22:55 ` Pedro Alves [this message]
2007-12-06 21:41 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47572BDD.2090803@portugalmail.pt \
--to=pedro_alves@portugalmail.pt \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox