From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20167 invoked by alias); 5 Dec 2007 22:53:30 -0000 Received: (qmail 20152 invoked by uid 22791); 5 Dec 2007 22:53:29 -0000 X-Spam-Check-By: sourceware.org Received: from nf-out-0910.google.com (HELO nf-out-0910.google.com) (64.233.182.191) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Dec 2007 22:53:22 +0000 Received: by nf-out-0910.google.com with SMTP id b11so3381583nfh for ; Wed, 05 Dec 2007 14:53:19 -0800 (PST) Received: by 10.78.136.9 with SMTP id j9mr1434347hud.1196895197023; Wed, 05 Dec 2007 14:53:17 -0800 (PST) Received: from ?88.210.66.24? ( [88.210.66.24]) by mx.google.com with ESMTPS id k5sm980250nfd.2007.12.05.14.53.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 05 Dec 2007 14:53:16 -0800 (PST) Message-ID: <47572BDD.2090803@portugalmail.pt> Date: Wed, 05 Dec 2007 22:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: Jim Blandy CC: gdb-patches@sourceware.org Subject: Re: COMMIT: addrmap changes References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00094.txt.bz2 Hi Jim, Jim Blandy wrote: > I've committed the following, approved in another thread. > From the thread you've posted this first, I understood this was work in progress, so most likelly you're already addressing a few of these issues, but in case they slip through: - GDB sources are now GPL v3 - I believe we're not allowed to use c99 features yet (designated initializers in addrmap_fixed_funcs). and being picky: - suspicious call to abort, should be gdb_assert, or internal_error ? - #if 1 -- Pedro Alves