From: Lerele <lerele@champenstudios.com>
To: Pedro Alves <pedro_alves@portugalmail.pt>,
gdb-patches@sourceware.org,
Lerele <lerele@champenstudios.com>
Subject: Re: [gdbserver/win32] (3/11) Fix suspend count handling
Date: Sat, 01 Dec 2007 19:36:00 -0000 [thread overview]
Message-ID: <4751B674.50306@champenstudios.com> (raw)
In-Reply-To: <20071201185337.GB24231@caradoc.them.org>
Just a couple small tiny details:
Not that it's super important, but in all the series of patches where
both our names appear, I think my name should be listed second (if at
all) in the changelog, as Pedro did the vast majority of the work for
these patches, and merged with the one I sent.
What's fair, is fair, I think. :)
Also, is it necessary to include the eMail?
I'd prefer not to include mine if this is possible, if this can lower
spam getting into my mail box.
Daniel Jacobowitz escribió:
> On Mon, Nov 12, 2007 at 02:06:59AM +0000, Pedro Alves wrote:
>
>> I have yet to turn this into a proper gdb test. Is that wanted? Where
>> shall I put it? gdb.base? gdb.thread? other?
>>
>
> gdb.threads would be good, I think.
>
>
>> 2007-11-12 Leo Zayas <lerele@champenstudios@com>
>> Pedro Alves <pedro_alves@portugalmail.pt>
>>
>> * win32-low.h (win32_thread_info): Add descriptions to the
>> structure members . Replace `suspend_count' counter by a
>> `suspended' flag.
>>
>> * win32-low.c (thread_rec): Update condition of when to get the
>> context from the inferior. Rely on ContextFlags being set if it
>> has already been retrieved. Only suspend the inferior thread if
>> we haven't already. Warn if that fails.
>> (continue_one_thread): s/suspend_count/suspended/. Only call
>> ResumeThread once. Warn if that fails.
>>
>
> OK.
>
>
next prev parent reply other threads:[~2007-12-01 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 2:07 Pedro Alves
2007-12-01 18:53 ` Daniel Jacobowitz
2007-12-01 19:36 ` Lerele [this message]
2007-12-03 3:53 ` Pedro Alves
2007-12-03 3:53 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4751B674.50306@champenstudios.com \
--to=lerele@champenstudios.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox