From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25620 invoked by alias); 1 Dec 2007 19:36:35 -0000 Received: (qmail 25612 invoked by uid 22791); 1 Dec 2007 19:36:34 -0000 X-Spam-Check-By: sourceware.org Received: from gw.sprintaddict.net (HELO champenstudios.com) (80.91.89.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Dec 2007 19:36:28 +0000 Received: from [192.168.1.5] (164.Red-80-36-45.staticIP.rima-tde.net [80.36.45.164]) (authenticated bits=0) by champenstudios.com (8.13.8/8.13.8) with ESMTP id lB1JNGJP014636 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sat, 1 Dec 2007 20:23:17 +0100 Message-ID: <4751B674.50306@champenstudios.com> Date: Sat, 01 Dec 2007 19:36:00 -0000 From: Lerele User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org, Lerele Subject: Re: [gdbserver/win32] (3/11) Fix suspend count handling References: <4737B543.80607@portugalmail.pt> <20071201185337.GB24231@caradoc.them.org> In-Reply-To: <20071201185337.GB24231@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00026.txt.bz2 Just a couple small tiny details: Not that it's super important, but in all the series of patches where both our names appear, I think my name should be listed second (if at all) in the changelog, as Pedro did the vast majority of the work for these patches, and merged with the one I sent. What's fair, is fair, I think. :) Also, is it necessary to include the eMail? I'd prefer not to include mine if this is possible, if this can lower spam getting into my mail box. Daniel Jacobowitz escribió: > On Mon, Nov 12, 2007 at 02:06:59AM +0000, Pedro Alves wrote: > >> I have yet to turn this into a proper gdb test. Is that wanted? Where >> shall I put it? gdb.base? gdb.thread? other? >> > > gdb.threads would be good, I think. > > >> 2007-11-12 Leo Zayas >> Pedro Alves >> >> * win32-low.h (win32_thread_info): Add descriptions to the >> structure members . Replace `suspend_count' counter by a >> `suspended' flag. >> >> * win32-low.c (thread_rec): Update condition of when to get the >> context from the inferior. Rely on ContextFlags being set if it >> has already been retrieved. Only suspend the inferior thread if >> we haven't already. Warn if that fails. >> (continue_one_thread): s/suspend_count/suspended/. Only call >> ResumeThread once. Warn if that fails. >> > > OK. > >