From: Pedro Alves <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org
Subject: Re: [win32] Fix watchpoint support
Date: Sat, 24 Nov 2007 12:22:00 -0000 [thread overview]
Message-ID: <4748175A.9010203@portugalmail.pt> (raw)
In-Reply-To: <20071123011301.GA31259@ednor.casa.cgf.cx>
Christopher Faylor wrote:
>> 2007-11-21 Pedro Alves <pedro_alves@portugalmail.pt>
>>
>> * win32-nat.c (win32_add_thread): Set Dr6 to 0xffff0ff0.
>> (win32_continue): Resume threads and set the debug registers
>> before calling ContinueDebugEvent.
>
> I'm not clear on how this differs from your other patch. It seems to do
> many of the same things. The principles are ok but it doesn't seem like
> it could be applied in addition to the suspend count handling patch.
>
Oh, that's because the last patch I sent on the other thread
had this one merged in [1], because after discussing it with
Pierre, we came to the conclusion this was needed for a full
fix of the other bug. I though merging it would be better for you,
since you'd only need to review one patch. I was wrong then.
Sorry. :/
[1]
http://sourceware.org/ml/gdb-patches/2007-11/msg00402.html
Cheers,
Pedro Alves
prev parent reply other threads:[~2007-11-24 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 0:35 Pedro Alves
2007-11-21 15:22 ` Pierre Muller
2007-11-21 23:33 ` Pedro Alves
2007-11-23 1:13 ` Christopher Faylor
2007-11-24 12:22 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4748175A.9010203@portugalmail.pt \
--to=pedro_alves@portugalmail.pt \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox