From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8681 invoked by alias); 24 Nov 2007 12:22:04 -0000 Received: (qmail 8671 invoked by uid 22791); 24 Nov 2007 12:22:04 -0000 X-Spam-Check-By: sourceware.org Received: from mu-out-0910.google.com (HELO mu-out-0910.google.com) (209.85.134.187) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Nov 2007 12:21:56 +0000 Received: by mu-out-0910.google.com with SMTP id g7so125114muf for ; Sat, 24 Nov 2007 04:21:52 -0800 (PST) Received: by 10.82.118.2 with SMTP id q2mr1063906buc.1195906912383; Sat, 24 Nov 2007 04:21:52 -0800 (PST) Received: from ?88.210.72.146? ( [88.210.72.146]) by mx.google.com with ESMTPS id 5sm3039219nfv.2007.11.24.04.21.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 24 Nov 2007 04:21:51 -0800 (PST) Message-ID: <4748175A.9010203@portugalmail.pt> Date: Sat, 24 Nov 2007 12:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [win32] Fix watchpoint support References: <47437D49.6080600@portugalmail.pt> <20071123011301.GA31259@ednor.casa.cgf.cx> In-Reply-To: <20071123011301.GA31259@ednor.casa.cgf.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00448.txt.bz2 Christopher Faylor wrote: >> 2007-11-21 Pedro Alves >> >> * win32-nat.c (win32_add_thread): Set Dr6 to 0xffff0ff0. >> (win32_continue): Resume threads and set the debug registers >> before calling ContinueDebugEvent. > > I'm not clear on how this differs from your other patch. It seems to do > many of the same things. The principles are ok but it doesn't seem like > it could be applied in addition to the suspend count handling patch. > Oh, that's because the last patch I sent on the other thread had this one merged in [1], because after discussing it with Pierre, we came to the conclusion this was needed for a full fix of the other bug. I though merging it would be better for you, since you'd only need to review one patch. I was wrong then. Sorry. :/ [1] http://sourceware.org/ml/gdb-patches/2007-11/msg00402.html Cheers, Pedro Alves